-
Notifications
You must be signed in to change notification settings - Fork 689
chore(main): release 1.494.0 #5837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release 1.494.0 #5837
Conversation
Deploying windmill with
|
Latest commit: |
6a0f5f0
|
Status: | ✅ Deploy successful! |
Preview URL: | https://77115317.windmill.pages.dev |
Branch Preview URL: | https://release-please--branches--ma.windmill.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 05a47ea in 22 seconds. Click for details.
- Reviewed
24
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. version.txt:1
- Draft comment:
Version updated to 1.494.0; update is consistent with release notes. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_hffYtQeoMGcTQtZR
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
6bd140a
to
ec773c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed ec773c9 in 28 seconds. Click for details.
- Reviewed
29
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. version.txt:1
- Draft comment:
Version number updated to 1.494.0. Confirm that this matches the changelog and any related version references for consistency. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_pNkeaosn8FHXJAbK
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
b29c875
to
94683c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 94683c5 in 28 seconds. Click for details.
- Reviewed
29
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. version.txt:1
- Draft comment:
Version bump updated to 1.494.0 correctly. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_JwA165X0NjwoAnXe
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
27df54e
to
8c0b1ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 8c0b1ed in 1 minute and 21 seconds. Click for details.
- Reviewed
30
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
3
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. version.txt:1
- Draft comment:
Version bump updated correctly to 1.494.0. Ensure this is in sync with the CHANGELOG and any other references. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. CHANGELOG.md:8
- Draft comment:
Typo suggestion: Consider capitalizing “s3” as “S3” if that better aligns with our naming convention. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% This is a purely stylistic suggestion about capitalization in a changelog, not a code change. The rules explicitly say not to make comments unless a code change is required. There is no evidence that this is a required change, and it is not actionable in terms of code logic or quality. It is not a bug or a logic issue. Perhaps consistent naming conventions are important for documentation, but the rules prioritize code changes over stylistic or documentation suggestions. Even if naming conventions are important, the rules are clear that such comments should not be made unless a code change is required. This is not the case here. This comment should be deleted as it is purely stylistic and not required by the rules.
3. CHANGELOG.md:14
- Draft comment:
Typographical suggestion: “allow disable tabs” might be intended as “allow disabling tabs” or “allow disabled tabs.” Please confirm the correct phrasing. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The comment is about a change in the diff, but it violates the rule against asking the author to confirm their intention. It is also a minor typographical suggestion, which may not warrant a code change. The suggestion itself is reasonable, but the phrasing of the comment makes it non-actionable and not strictly necessary. Perhaps the suggestion could be made more actionable by directly suggesting the change without asking for confirmation. However, as written, it does not meet the criteria for a useful review comment. Even if the suggestion is valid, the comment's format and intent do not align with the review rules. It should be deleted unless rewritten as a direct, actionable suggestion. The comment should be deleted because it is not actionable and asks for confirmation, violating the review rules.
Workflow ID: wflow_VaHNhX5pFJe5CTs0
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
6a0f5f0
to
561c46f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 561c46f in 25 seconds. Click for details.
- Reviewed
30
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. version.txt:1
- Draft comment:
Version bumped to 1.494.0; verify this syncs with changelog release. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_LWsmbbr0Ic4vLdjT
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
🤖 Release is at https://github.com/windmill-labs/windmill/releases/tag/v1.494.0 🌻 |
🤖 I have created a release beep boop
1.494.0 (2025-05-31)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.
Important
Release 1.494.0 adds S3 object array input, shared Rust build directory, and fixes tab disabling.
version.txt
to 1.494.0.CHANGELOG.md
with release notes for 1.494.0.This description was created by
for 561c46f. You can customize this summary. It will automatically update as commits are pushed.