Skip to content

fix: allow disable tabs for sidebar/accordion tabs #5838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented May 29, 2025

Important

Add functionality to disable specific tabs in AppTabs.svelte using resolvedDisabledTabs.

  • Behavior:
    • Tabs can now be disabled in AppTabs.svelte using resolvedDisabledTabs array.
    • Disabled tabs have opacity-50 and cursor-not-allowed styles, and do not trigger selection on click.
  • Code Changes:
    • Updated on:click handlers in AppTabs.svelte to check resolvedDisabledTabs before changing selected.
    • Added disabled attribute to buttons in AppTabs.svelte to reflect disabled state.
    • Applied conditional styles for disabled tabs in AppTabs.svelte.

This description was created by Ellipsis for 7f4b82c. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7f4b82c in 1 minute and 1 seconds. Click for details.
  • Reviewed 48 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/lib/components/apps/components/layout/AppTabs.svelte:131
  • Draft comment:
    Added 'index' in the #each loop to map tabs with their disabled state. Ensure downstream components (e.g. ) properly handle the disabled prop.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. frontend/src/lib/components/apps/components/layout/AppTabs.svelte:156
  • Draft comment:
    The on:click handler now only updates 'selected' if the tab isn’t disabled. This prevents undesired tab switching. Consider extracting this inline logic to a helper for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. frontend/src/lib/components/apps/components/layout/AppTabs.svelte:186
  • Draft comment:
    Similar conditional logic on the accordion tab button prevents selection when disabled. Consider consolidating the repeated disabled styling logic.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
4. frontend/src/lib/components/apps/components/layout/AppTabs.svelte:132
  • Draft comment:
    The component now receives a disabled prop. Verify that enforces this disabled state internally for consistent behavior.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_5YIJh0RgP9APd1nd

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7f4b82c
Status: ✅  Deploy successful!
Preview URL: https://fda24522.windmill.pages.dev
Branch Preview URL: https://alp-fix-disable-tabs.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 80277d1 into main May 29, 2025
12 checks passed
@rubenfiszel rubenfiszel deleted the alp/fix_disable_tabs branch May 29, 2025 16:52
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants