Skip to content

feat: add inkeep endpoint #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat: add inkeep endpoint #5845

wants to merge 4 commits into from

Conversation

centdix
Copy link
Collaborator

@centdix centdix commented May 31, 2025

Important

Add /inkeep endpoint with conditional private feature handling in lib.rs and inkeep_oss.rs.

  • Behavior:
    • Adds /inkeep endpoint to the server in run_server() in lib.rs.
    • Uses inkeep_ee::global_service() for private feature, otherwise uses Router::new().
  • Modules:
    • Adds mod inkeep_ee and mod inkeep_oss in lib.rs.
    • Creates inkeep_oss.rs with conditional compilation for private and non-private features.

This description was created by Ellipsis for 25c8e6e. You can customize this summary. It will automatically update as commits are pushed.

Copy link

cloudflare-workers-and-pages bot commented May 31, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 25c8e6e
Status:🚫  Build failed.

View logs

@centdix centdix force-pushed the inkeep-endpoint branch from 07d2887 to 2fab5c3 Compare June 2, 2025 11:36
@centdix centdix marked this pull request as ready for review June 2, 2025 11:46
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 2fab5c3 in 38 seconds. Click for details.
  • Reviewed 38 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. backend/ee-repo-ref.txt:1
  • Draft comment:
    Updated commit hash. Ensure this update is intentional and that all dependent services are compatible with it.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. backend/windmill-api/src/inkeep_ee.rs:3
  • Draft comment:
    The new inkeep endpoint is currently a placeholder returning an empty router. Consider adding documentation or preliminary routes to clarify its intended future functionality.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. backend/windmill-api/src/lib.rs:583
  • Draft comment:
    The /inkeep route is added similarly to other endpoints. Confirm that it does not require additional middleware (e.g., auth or CORS) if needed for consistent security and behavior.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_B0A7OpZFWlz1ycAu

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@centdix centdix force-pushed the inkeep-endpoint branch from 2fab5c3 to 25c8e6e Compare June 3, 2025 14:08
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 25c8e6e in 34 seconds. Click for details.
  • Reviewed 8 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. backend/ee-repo-ref.txt:1
  • Draft comment:
    Added trailing newline for consistency. This adheres to best practices.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_BrUlGsgXvvYq9OP9

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@centdix centdix closed this Jun 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant