Skip to content

[Claude PR] Fix HTTP connection issue for schedule triggers #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

claude[bot]
Copy link
Contributor

@claude claude bot commented Jun 1, 2025

Summary

Fixed the issue where schedule triggers couldn't be created when connecting to Windmill over HTTP. The problem was caused by crypto.randomUUID() requiring a secure context (HTTPS), which broke functionality for users on internal HTTP networks.

Changes Made

  • Replaced crypto.randomUUID() with generateRandomString() in triggers.svelte.ts
  • Added generateRandomString import from $lib/utils
  • The generateRandomString() function uses Math.random() which works in any context

Issue Reference

Fixes #5847

Test Plan

  • Verify the change compiles correctly
  • Test schedule trigger creation on HTTP connection
  • Ensure generated IDs are still unique and functional

Generated with Claude Code


Important

Replaces crypto.randomUUID() with generateRandomString() in triggers.svelte.ts to fix schedule trigger creation over HTTP.

  • Behavior:
    • Replaces crypto.randomUUID() with generateRandomString() in triggers.svelte.ts to fix schedule trigger creation over HTTP.
    • generateRandomString() uses Math.random() to work in any context.
  • Imports:
    • Adds generateRandomString import from $lib/utils in triggers.svelte.ts.
  • Testing:
    • Verify compilation and test schedule trigger creation on HTTP.
    • Ensure generated IDs are unique and functional.

This description was created by Ellipsis for d0a4456. You can customize this summary. It will automatically update as commits are pushed.

…patibility

Replace crypto.randomUUID() with generateRandomString() in triggers.svelte.ts 
to fix schedule trigger creation on HTTP connections. The crypto.randomUUID() 
API requires a secure context (HTTPS), which breaks functionality for users 
connecting to Windmill over HTTP in internal networks.

Fixes #5847

Co-authored-by: rubenfiszel <[email protected]>
Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: d0a4456
Status: ✅  Deploy successful!
Preview URL: https://156340ec.windmill.pages.dev
Branch Preview URL: https://claude-issue-5847-20250601-0.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel marked this pull request as ready for review June 1, 2025 17:44
@rubenfiszel rubenfiszel merged commit 64f35d0 into main Jun 1, 2025
8 checks passed
@rubenfiszel rubenfiszel deleted the claude/issue-5847-20250601_081538 branch June 1, 2025 17:44
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d0a4456 in 28 seconds. Click for details.
  • Reviewed 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/lib/components/triggers/triggers.svelte.ts:23
  • Draft comment:
    Added generateRandomString to imports. Ensure that generateRandomString reliably produces unique IDs to avoid collisions, since it now replaces crypto.randomUUID().
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. frontend/src/lib/components/triggers/triggers.svelte.ts:97
  • Draft comment:
    Replacing crypto.randomUUID() with generateRandomString() fixes HTTPS requirement. Confirm that the alternative provides sufficient uniqueness for draft trigger IDs.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_50wDSyVOqfd3Q9gt

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create schedule trigger on HTTP connection
1 participant