-
Notifications
You must be signed in to change notification settings - Fork 690
chore: fix python client build #5856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying windmill with
|
Latest commit: |
3a45a57
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b9cc3860.windmill.pages.dev |
Branch Preview URL: | https://fix-python-client-oapi.windmill.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 9fc7146 in 1 minute and 49 seconds. Click for details.
- Reviewed
84
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
4
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. flake.nix:95
- Draft comment:
Consider pinning the versions for the newly added dependencies (poetry, pyright, openapi-python-client) to ensure reproducible builds. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
2. python-client/build.sh:8
- Draft comment:
Typo: 'compatability' should be spelled 'compatibility'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the spelling correction is technically accurate, our rules state we should only keep comments that require clear code changes. This is just a typo in a comment, not in actual code. It's a very minor issue that doesn't affect functionality. Comments about pure documentation/comments are generally not worth keeping unless they point out seriously misleading information. The typo could potentially confuse future developers looking at the code. Documentation quality is important for maintainability. While documentation is important, this is a minor spelling error that doesn't impede understanding. The meaning is still clear despite the typo. Delete this comment as it's about a minor spelling error in documentation that doesn't impact code functionality or comprehension.
3. python-client/publish.sh:6
- Draft comment:
Quote the $PYPI_PASSWORD variable (e.g. use "--password "$PYPI_PASSWORD"") to prevent word splitting. Also, verify if using '|| true' to suppress publish errors is intentional. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. python-client/build.sh:8
- Draft comment:
Typo: "compatability" should be "compatibility". - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While this is technically correct - there is a misspelling - it's just a typo in a comment. Comments are documentation and should be correct, but this is an extremely minor issue. The meaning is completely clear despite the typo. This feels like the kind of nitpicky comment that creates noise without adding value. Comments should be clear and correct for documentation purposes. Poor spelling could indicate lack of attention to detail. While correct spelling is good, this typo doesn't impact code functionality or clarity. The rules state not to make obvious or unimportant comments. This comment should be deleted as it's too minor and doesn't affect code quality or functionality.
Workflow ID: wflow_Zlrmgbl0ya6m4yvp
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix Python client build by updating OpenAPI processing and dependencies in
flake.nix
.build.sh
, replace inline OpenAPI schema with legacy wildcard for compatibility.perl
for macOS andsed
for other systems to processopenapi.yaml
.poetry
,pyright
, andopenapi-python-client
toflake.nix
.#!/usr/bin/env bash
inbuild.sh
andpublish.sh
.publish.sh
, usepoetry
to publish packages withPYPI_PASSWORD
.openapi.yaml
to mark inline schema sections.This description was created by
for 9fc7146. You can customize this summary. It will automatically update as commits are pushed.