Skip to content

fix: nit ai flow prompt #5867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: nit ai flow prompt #5867

merged 1 commit into from
Jun 4, 2025

Conversation

HugoCasa
Copy link
Collaborator

@HugoCasa HugoCasa commented Jun 4, 2025

Important

Improves prompt messages for script searches and step additions in core.ts, and updates documentation for step execution order.

  • Behavior:
    • Enhanced prompt messages in flowTools for searchScriptsToolDef and searchHubScriptsToolDef to include query context.
    • Simplified return message for step addition in addStepToolDef to always show the updated flow.
  • Documentation:
    • Updated instructions in prepareFlowSystemMessage to clarify step addition order and execution sequence.
    • Added note on step execution order in prepareFlowSystemMessage.

This description was created by Ellipsis for 323bec1. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 323bec1 in 1 minute and 31 seconds. Click for details.
  • Reviewed 83 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/lib/components/copilot/chat/flow/core.ts:335
  • Draft comment:
    Nit: Consider using template literals for composing the search message (e.g., Searching for workspace scripts related to "${parsedArgs.query}"...) and using the parsed arguments (parsedArgs.query) consistently instead of args.query.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. frontend/src/lib/components/copilot/chat/flow/core.ts:353
  • Draft comment:
    Nit: For the hub scripts search, consider using template literals for clarity and use the parsed arguments (parsedArgs.query) for consistency in the log messages.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. frontend/src/lib/components/copilot/chat/flow/core.ts:397
  • Draft comment:
    The removal of conditional messages in the add step tool simplifies the prompt. Make sure that the single message (which always shows the full updated flow) is sufficient, especially for steps added in subflow contexts (e.g. inside a branch or forloop).
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure that a specific behavior is sufficient, which violates the rule against asking the author to ensure behavior is intended or tested. It does not provide a specific suggestion or point out a clear issue.
4. frontend/src/lib/components/copilot/chat/flow/core.ts:591
  • Draft comment:
    The updated documentation text is clearer regarding special instructions for adding steps and emphasizes the execution order. Confirm that this revised wording fully reflects the intended behavior.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
5. frontend/src/lib/components/copilot/chat/flow/core.ts:591
  • Draft comment:
    Typographical consistency: The header on line 591 uses 'forloop' in singular form, whereas the body refers to 'forloops' (plural). Consider updating the header to '### Branchone/branchall and forloops' for consistent terminology.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_5brakbFaFpBcqFDX

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 323bec1
Status: ✅  Deploy successful!
Preview URL: https://f18f31f3.windmill.pages.dev
Branch Preview URL: https://hc-nit-ai-flow-prompt.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 3e769f0 into main Jun 4, 2025
12 checks passed
@rubenfiszel rubenfiszel deleted the hc/nit-ai-flow-prompt branch June 4, 2025 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants