-
Notifications
You must be signed in to change notification settings - Fork 693
feat: Fix menu button on mobile + show accept all when code is applied from script chat #5872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying windmill with
|
Latest commit: |
2383336
|
Status: | ✅ Deploy successful! |
Preview URL: | https://4e1ba295.windmill.pages.dev |
Branch Preview URL: | https://fg-ask-mode.windmill.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 2383336 in 1 minute and 46 seconds. Click for details.
- Reviewed
102
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
7
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/lib/components/copilot/chat/AIChatManager.svelte.ts:70
- Draft comment:
Added 'pendingNewCode' state. Ensure using a single global state is safe if multiple editor instances exist. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
2. frontend/src/lib/components/copilot/chat/monaco-adapter.ts:33
- Draft comment:
Removed local 'pendingNewCode' and now referencing aiChatManager.pendingNewCode. Verify that this shared state doesn’t lead to concurrency issues. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
3. frontend/src/lib/components/copilot/chat/monaco-adapter.ts:170
- Draft comment:
In reviewAndApply, if newCode equals pendingNewCode, acceptAll is called immediately. Confirm this is the intended user experience. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm their intention regarding the behavior of the code. This violates the rule against asking for confirmation of intention or ensuring behavior is intended.
4. frontend/src/lib/components/copilot/chat/script/CodeDisplay.svelte:183
- Draft comment:
Button now renders only when code differs from scriptEditorOptions.code. Ensure that valid cases aren’t unintentionally hidden. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
5. frontend/src/lib/components/copilot/chat/script/CodeDisplay.svelte:192
- Draft comment:
Button label shows 'Accept all' when pendingNewCode is truthy. Confirm consistency with the review workflow. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
6. frontend/src/routes/(root)/(logged)/+layout.svelte:680
- Draft comment:
Removed 'items-center justify-center' from mobile menu button classes. Check that the menu icon remains centered on mobile. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
7. frontend/src/routes/(root)/(logged)/+layout.svelte:672
- Draft comment:
Updated padding and flex-row classes in container div for mobile menu. Verify UI alignment across breakpoints. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_wQ0QDICroL8ecQKs
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 2355efa in 40 seconds. Click for details.
- Reviewed
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/routes/(root)/(logged)/+layout.svelte:682
- Draft comment:
Adding the 'items-center justify-center' classes properly centers the menu icon on mobile. This improves button alignment; no further changes needed. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_8wtIHGWIaQM3UcFi
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Important
Fixes mobile menu button and updates 'Apply' button to 'Accept all' when code is applied from script chat, using
pendingNewCode
state.pendingNewCode
state inAIChatManager.svelte.ts
to track new code application.reviewAndApply()
inmonaco-adapter.ts
to usependingNewCode
for code acceptance logic.CodeDisplay.svelte
whenpendingNewCode
is set.+layout.svelte
to ensure proper display.MenuButton
in+layout.svelte
to toggle AI chat visibility.This description was created by
for 2355efa. You can customize this summary. It will automatically update as commits are pushed.