Skip to content

feat: Fix menu button on mobile + show accept all when code is applied from script chat #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025

Conversation

centdix
Copy link
Collaborator

@centdix centdix commented Jun 5, 2025

Important

Fixes mobile menu button and updates 'Apply' button to 'Accept all' when code is applied from script chat, using pendingNewCode state.

  • Behavior:
    • Introduces pendingNewCode state in AIChatManager.svelte.ts to track new code application.
    • Updates reviewAndApply() in monaco-adapter.ts to use pendingNewCode for code acceptance logic.
    • Changes button label from 'Apply' to 'Accept all' in CodeDisplay.svelte when pendingNewCode is set.
  • UI Adjustments:
    • Fixes mobile menu button padding in +layout.svelte to ensure proper display.
    • Adjusts MenuButton in +layout.svelte to toggle AI chat visibility.

This description was created by Ellipsis for 2355efa. You can customize this summary. It will automatically update as commits are pushed.

@centdix centdix marked this pull request as ready for review June 5, 2025 14:03
Copy link

cloudflare-workers-and-pages bot commented Jun 5, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2383336
Status: ✅  Deploy successful!
Preview URL: https://4e1ba295.windmill.pages.dev
Branch Preview URL: https://fg-ask-mode.windmill.pages.dev

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 2383336 in 1 minute and 46 seconds. Click for details.
  • Reviewed 102 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/lib/components/copilot/chat/AIChatManager.svelte.ts:70
  • Draft comment:
    Added 'pendingNewCode' state. Ensure using a single global state is safe if multiple editor instances exist.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
2. frontend/src/lib/components/copilot/chat/monaco-adapter.ts:33
  • Draft comment:
    Removed local 'pendingNewCode' and now referencing aiChatManager.pendingNewCode. Verify that this shared state doesn’t lead to concurrency issues.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
3. frontend/src/lib/components/copilot/chat/monaco-adapter.ts:170
  • Draft comment:
    In reviewAndApply, if newCode equals pendingNewCode, acceptAll is called immediately. Confirm this is the intended user experience.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm their intention regarding the behavior of the code. This violates the rule against asking for confirmation of intention or ensuring behavior is intended.
4. frontend/src/lib/components/copilot/chat/script/CodeDisplay.svelte:183
  • Draft comment:
    Button now renders only when code differs from scriptEditorOptions.code. Ensure that valid cases aren’t unintentionally hidden.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
5. frontend/src/lib/components/copilot/chat/script/CodeDisplay.svelte:192
  • Draft comment:
    Button label shows 'Accept all' when pendingNewCode is truthy. Confirm consistency with the review workflow.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
6. frontend/src/routes/(root)/(logged)/+layout.svelte:680
  • Draft comment:
    Removed 'items-center justify-center' from mobile menu button classes. Check that the menu icon remains centered on mobile.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
7. frontend/src/routes/(root)/(logged)/+layout.svelte:672
  • Draft comment:
    Updated padding and flex-row classes in container div for mobile menu. Verify UI alignment across breakpoints.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_wQ0QDICroL8ecQKs

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 2355efa in 40 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/routes/(root)/(logged)/+layout.svelte:682
  • Draft comment:
    Adding the 'items-center justify-center' classes properly centers the menu icon on mobile. This improves button alignment; no further changes needed.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_8wtIHGWIaQM3UcFi

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@rubenfiszel rubenfiszel merged commit d86dcc6 into main Jun 5, 2025
8 of 9 checks passed
@rubenfiszel rubenfiszel deleted the fg/ask-mode branch June 5, 2025 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants