Skip to content

Update routing-controller.md #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2015
Merged

Update routing-controller.md #5

merged 3 commits into from
Jan 8, 2015

Conversation

skylying
Copy link
Contributor

@skylying skylying commented Jan 5, 2015

分批來


Why we don't need to include this file? Windwalker use autoloading to find classes. The `/src` folder use [PSR](http://www.php-fig.org/psr/psr-4/)
rule to match class namespace with folder structure, it because we have already set `"": "src/"` in `composer.json`.
All php clases within `/src` folder hierarchy will be loaded automatically once you add `"": "src/"` as [PSR](http://www.php-fig.org/psr/psr-4/) standard in `composer.json`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊是想說[我們已經這樣做了],而不是[你可以這樣做]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

阿要怎樣補 commit 啊, 這個 PR 發的太虛幻了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在你的 repo 改即可,你的 repo 會有一個 patch-x 的 branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: classes

@skylying
Copy link
Contributor Author

skylying commented Jan 8, 2015

ok, 有了
你看看吧

@asika32764
Copy link
Member

👍

asika32764 added a commit that referenced this pull request Jan 8, 2015
Update routing-controller.md
@asika32764 asika32764 merged commit 48969af into windwalker-io:master Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants