[WPB-16870] introduce user groups subsystem #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
fisx
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
2 times, most recently
from
a5e1731 to
e119925
Compare
2 tasks
akshaymankar
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
3 times, most recently
from
142fca5 to
88a5c27
Compare
fisx
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
from
71c726a to
29a7243
Compare
battermann
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
from
29a7243 to
18ad40b
Compare
fisx
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
4 times, most recently
from
18b5565 to
a83888f
Compare
fisx
commented
May 7, 2025
battermann
requested changes
May 9, 2025
pcapriotti
approved these changes
May 13, 2025
fisx
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
from
43ba624 to
f6cbad0
Compare
fisx
commented
May 13, 2025
libs/wire-subsystems/test/unit/Wire/UserGroupSubsystem/InterpreterSpec.hs
Show resolved
Hide resolved
akshaymankar
approved these changes
May 14, 2025
Comment on lines
+11
to
+12
| testUserGroupSmoke :: (HasCallStack) => App () | ||
| testUserGroupSmoke = do |
There was a problem hiding this comment.
it just kicks the api a little to see if it's superficially acting alive. i thought smoke test describes that well, but i don't mind a better name. do you have one?
Comment on lines
+69
to
+73
| sanitized :: Wai.Error | ||
| sanitized = | ||
| if Wai.code e == status500 | ||
| then e {Wai.message = "Internal Server Error"} | ||
| else e |
There was a problem hiding this comment.
Does logging of this error happen before or after this point?
There was a problem hiding this comment.
before, that's the point. this is right before we send it on the wire.
Comment on lines
+81
to
+89
| admins <- getTeamAdmins team | ||
| let push = | ||
| def | ||
| { origin = Just creator, | ||
| json = toJSONObject $ UserGroupEvent $ UserGroupCreated ug.id_, | ||
| recipients = (\tm -> Recipient (tm ^. TM.userId) RecipientClientsAll) <$> admins ^. teamMembers, | ||
| transient = True | ||
| } | ||
| pushNotifications [push] |
There was a problem hiding this comment.
Given user groups is a search now and team management doesn't have to load them all up. Does this event make any sense?
There was a problem hiding this comment.
hm, not sure. happy to remove it if that's what we decide.
featuring: - effect - data types - test skeleton - mock interpreter skeleton
the qualified import in Main is needed for some test setups involving ghcid and cabal-repl; moving all deps to the common section in the cabal file just seemed more ergonomic?
This reverts commit 73c397a.
battermann
force-pushed
the
WPB-16870-user-groups-create-and-get
branch
from
ff95607 to
446d703
Compare
battermann
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-16870
this adds a wire subsystem for user groups with tests and in-memory interpreter.
coming up in future PRs:
Checklist
changelog.dRead and follow the PR guidelines (can't at the moment)