Skip to content

WPB-17655 fix saml auth resp parsing #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2025
Merged

WPB-17655 fix saml auth resp parsing #4577

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd5d784
[drive-by] fix aeson bounds.
fisx May 14, 2025
6d0a367
Save counter-example and test draft.
fisx May 14, 2025
54d9f5f
Work-around missing utf8 support in hxt parser.
fisx May 15, 2025
a18f4df
Changelog; link upstream PR.
fisx May 15, 2025
416753a
make sanitize-pr
fisx May 15, 2025
60ecece
make sanitize-pr
supersven May 16, 2025
a9dc164
Clean up sample xml files.
fisx May 16, 2025
71c28eb
Fix filenames in test
supersven May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changelog; link upstream PR.
  • Loading branch information
@fisx
fisx committed May 15, 2025
commit a18f4dfeb7dc07693303f580af001487b16b75ea
1 change: 1 addition & 0 deletions changelog.d/3-bug-fixes/WPB-17655-fix-saml-auth-resp-parsing
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
hxt doesn't support all of unicode (it decodes utf8-encoded bytestrings as ascii-encoded using LBS.unpack). the related code and fix are now in saml2-web-sso.
2 changes: 2 additions & 0 deletions libs/saml2-web-sso/src/SAML2/WebSSO/XML/Hack.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ docToXMLWithRoot = xshowBlob . (: [])
-- | this is called in `xshowBlob` below and used to come from "Text.XML.HXT.DOM.TypeDefs".
-- the original in hxt used Data.ByteString.Lazy.Char8.pack for rendering XText, which caused
-- some valid unicode characters to get corrupted.
--
-- See also: https://github.com/UweSchmidt/hxt/pull/101/files
stringToBlob :: String -> BSL.ByteString
stringToBlob = LBSUTF8.fromString

Expand Down