Fix schema initialization exceptions (graphql-dotnet#3445)

Author: Shane32

src/GraphQL.Tests/Bugs/BugReport.cs

@@ -0,0 +1,33 @@
+using GraphQL.Types;
+
+namespace GraphQL.Tests.Bugs;
+
+public class Bug3444
+{
+    [Fact]
+    public void Rethrow_Schema_Initialization_Failure()
+    {
+        var queryType = new ObjectGraphType { Name = "Query" };
+        queryType.Field<TestOneType>("test1");
+        queryType.Field<TestTwoType>("test2");
+        var schema = new Schema() { Query = queryType };
+        var msg1 = Should.Throw<InvalidOperationException>(() => schema.Initialize()).Message;
+        var msg2 = Should.Throw<InvalidOperationException>(() => schema.Initialize()).Message;
+        msg1.ShouldBe(msg2);
+    }
+
+    private class TestOneType : EnumerationGraphType<TestEnum>
+    {
+    }
+
+    private class TestTwoType : EnumerationGraphType<TestEnum>
+    {
+    }
+
+    private enum TestEnum
+    {
+        One,
+        Two,
+        Three
+    }
+}

src/GraphQL/Types/Schema.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using System.Runtime.ExceptionServices;
 using GraphQL.Conversion;
 using GraphQL.DI;
 using GraphQL.Instrumentation;
@@ -74,6 +75,7 @@ public SchemaDebugView(Schema schema)
         private bool _disposed;
         private IServiceProvider _services;
         private SchemaTypes? _allTypes;
+        private ExceptionDispatchInfo? _initializationException;
         private readonly object _allTypesInitializationLock = new();
 
         private List<Type>? _additionalTypes;
@@ -201,9 +203,19 @@ public void Initialize()
                 if (Initialized)
                     return;
 
-                CreateAndInitializeSchemaTypes();
+                _initializationException?.Throw();
 
-                Initialized = true;
+                try
+                {
+                    CreateAndInitializeSchemaTypes();
+
+                    Initialized = true;
+                }
+                catch (Exception ex)
+                {
+                    _initializationException = ExceptionDispatchInfo.Capture(ex);
+                    throw;
+                }
             }
         }