Skip to content

Fix schema initialization exceptions #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Dec 7, 2022

@Shane32 Shane32 self-assigned this Dec 7, 2022
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Dec 7, 2022
@Shane32 Shane32 requested a review from sungam3r December 7, 2022 23:45
@codecov-commenter
Copy link

Codecov Report

Merging #3445 (79eb972) into master (997dfaa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3445   +/-   ##
=======================================
  Coverage   83.71%   83.71%           
=======================================
  Files         377      377           
  Lines       16392    16399    +7     
  Branches     2640     2641    +1     
=======================================
+ Hits        13722    13729    +7     
  Misses       2049     2049           
  Partials      621      621           
Impacted Files Coverage Δ
src/GraphQL/Types/Schema.cs 72.50% <100.00%> (+0.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sungam3r sungam3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

@sungam3r sungam3r added the enhancement New feature or request label Dec 8, 2022
@Shane32 Shane32 merged commit 2043e2d into master Dec 8, 2022
@Shane32 Shane32 deleted the schema_initialization_exceptions branch December 8, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialization problems are not thrown when calling Initialize a second time
3 participants