Fix #1822: Update vault unlock for crypto4 #2003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnpsk
approved these changes
Jul 11, 2025
| * @throws GenericServiceException Thrown in case vault unlock reason format is invalid. | ||
| */ | ||
| private void checkVaultUnlockReason(String reason) throws GenericServiceException { | ||
| if (reason != null && !reason.matches("[A-Za-z0-9_\\-.]{3,255}")) { |
There was a problem hiding this comment.
This will compile the regex into Pattern object every time. We can get some performance benefit by defining static final Pattern.
| * Decrypt the incoming AEAD request. | ||
| * | ||
| * @param request Vault unlock request. | ||
| * @return Vault unlok decryption result. |
There was a problem hiding this comment.
typo
Suggested change
| * @return Vault unlok decryption result. | |
| * @return Vault unlock decryption result. |
| * @throws GenericServiceException Thrown in case key identifier is invalid. | ||
| */ | ||
| private void checkKeyIdentifier(String keyIdentifier, AuthenticationCodeType authenticationCodeType, String applicationId) throws GenericServiceException { | ||
| if (keyIdentifier == null) { |
There was a problem hiding this comment.
the specification recommends a fallback to v3 if the identifier is null, but I guess this is solved by dedicated endpoints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of vault unlock for crypto4.