Skip to content

[plugin.video.mytv_bg] 2.0.8 #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2018
Merged

[plugin.video.mytv_bg] 2.0.8 #1930

merged 1 commit into from
Jul 25, 2018

Conversation

MiimMarkova
Copy link

Description

Checklist:

  • [ x] My code follows the add-on rules and piracy stance of this project.
  • [x ] I have read the CONTRIBUTING document
  • [ x] Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@TravisBuddy
Copy link

Travis Buddy

Hey MiimMarkova,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

__token_filepath__ = __profile_path__ + '/token.txt'


class Plugin(object):

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

li = xbmcgui.ListItem(label=show_title + ' ' + title)

#if we start video without stopping the previous
if player.isPlaying():

This comment was marked as spam.

This comment was marked as spam.

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about player

@TravisBuddy
Copy link

Travis Buddy

Hey MiimMarkova,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[splugin.video.mytv_bg] 2.0.8
@TravisBuddy
Copy link

Travis Buddy

Hey MiimMarkova,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@MiimMarkova
Copy link
Author

Hi,
When creating the list, the provided urls are not actual playable media urls. The media url is given after the item has been selected and setResolvedUrl at that point creates a loop. Also I need the xbmc.Player() because of its events. I don't see how I can change the player.

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm accepting this for now as it is sitting here for too long but I'll request the same change on the next update. I'll have a look into the issue you're facing with setResolvedUrl. Sorry for the delay.

@enen92 enen92 merged commit 93301f0 into xbmc:gotham Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants