Skip to content

Refactor code to PHP 8 style #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Refactor code to PHP 8 style #517

merged 1 commit into from
Oct 19, 2022

Conversation

githubjeka
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 31.17% // Head: 31.17% // No change to project coverage 👍

Coverage data is based on head (3033588) compared to base (51d163f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #517   +/-   ##
=========================================
  Coverage     31.17%   31.17%           
  Complexity      380      380           
=========================================
  Files            57       57           
  Lines          1235     1235           
=========================================
  Hits            385      385           
  Misses          850      850           
Impacted Files Coverage Δ
src/Middleware/LocaleMiddleware.php 26.85% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw requested a review from a team October 18, 2022 22:41
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Oct 18, 2022
@arogachev
Copy link
Contributor

arogachev commented Oct 19, 2022

This was also fixed earlier as a part of #506:

if (str_contains($locale, '-')) {
return explode('-', $locale, 2);
}
if (isset($this->locales[$locale]) && str_contains($this->locales[$locale], '-')) {

After adding rector such replacements will be done automatically. But until then, let's merge it separately. Thanks! 👍

@arogachev arogachev merged commit 96e8617 into yiisoft:master Oct 19, 2022
@arogachev arogachev added type:bug Bug type:task Task and removed type:bug Bug labels Oct 19, 2022
@githubjeka githubjeka deleted the str_contrain branch October 19, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:task Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants