Skip to content

(feat): full v2 compat via python fallback #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Feb 11, 2025
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c7fb95a
chore(deps): bump zarr to 3.0.0rc1
LDeakin Jan 3, 2025
0a877e0
fmt
LDeakin Jan 3, 2025
def2e70
(feat): python fallack
ilan-gold Jan 28, 2025
622287d
Merge branch 'main' into ig/python_fallback
ilan-gold Jan 29, 2025
b362759
(fix): dtypes
ilan-gold Jan 30, 2025
fba8226
(fix): `object` dtypes + `v2` tests
ilan-gold Jan 30, 2025
4aa21a3
(fix): `object` dtypes + `v2` tests
ilan-gold Jan 30, 2025
a51e810
(fix): `object` dtypes + `v2` tests
ilan-gold Jan 30, 2025
19e90e3
(fix): `object` dtypes in rust
ilan-gold Feb 2, 2025
4a59ec1
(fix): blosc support
ilan-gold Feb 2, 2025
45efee1
(refactor): handle `None` fill-value more gracefully
ilan-gold Feb 2, 2025
59e60fc
fix: V2 codec pipeline creation
LDeakin Feb 3, 2025
1a6dc77
fix: zfpy/pcodec metadata handling
LDeakin Feb 3, 2025
008fd6a
(fix): fall back for unsupported codecs
ilan-gold Feb 4, 2025
9a0daa9
(fix): our decode codec pipeline does not support vlen
ilan-gold Feb 4, 2025
4637d24
(fix): string dtype test to match zarr-python
ilan-gold Feb 4, 2025
cf2e6b5
(chore): add note
ilan-gold Feb 4, 2025
00e73ed
(fix): ruff
ilan-gold Feb 4, 2025
d8aa2cc
(fix): rustfmt
ilan-gold Feb 4, 2025
8ea80bc
(fix): `pyi`
ilan-gold Feb 4, 2025
db255a9
(fix): try removing zarr main branch dep
ilan-gold Feb 4, 2025
cb4bedc
fix: use upstream implicit fill values
LDeakin Feb 5, 2025
26ee516
fix: use upstream metadata handling
LDeakin Feb 5, 2025
6ff6c2b
fix: cleanup fill value handling for string dtype
LDeakin Feb 7, 2025
abe4dd5
Revert "fix: cleanup fill value handling for string dtype"
LDeakin Feb 7, 2025
a618605
fix: cleanup fill value handling for string dtype
LDeakin Feb 7, 2025
4159751
fix: fmt and clippy warnings
LDeakin Feb 7, 2025
ae194a6
fix: zarr-python 0 fill value handling
LDeakin Feb 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
(chore): add note
  • Loading branch information
ilan-gold committed Feb 4, 2025
commit cf2e6b5c8131b7eb00c8f43b1b8e4e4c09c2a63f
2 changes: 2 additions & 0 deletions tests/test_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ def test_v2_encode_decode_with_data(dtype_value, tmp_path):

@pytest.mark.parametrize("dtype", [str, "str"])
async def test_create_dtype_str(dtype: Any, tmp_path) -> None:
# see https://github.com/zarr-developers/zarr-python/issues/2627 for why this test
# is probably wrong
arr = zarr.create(store=tmp_path, shape=3, dtype=dtype, zarr_format=2)
assert arr.dtype.kind == "O"
assert arr.metadata.to_dict()["dtype"] == "|O"
Expand Down
Loading