-
Notifications
You must be signed in to change notification settings - Fork 4.6k
editor: Add minimap #26893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SomeoneToIgnore
merged 121 commits into
zed-industries:main
from
esimkowitz:evan/minimap
May 7, 2025
Merged
editor: Add minimap #26893
Changes from 1 commit
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
4ae4208
First attempt at minimap, currently getting stack overflow
esimkowitz ca33b7b
save work
esimkowitz 13f1355
okay I've got the minimap displaying without a stack overflow, but now I
esimkowitz d477cc0
scrollbar is now visible, fixed sizing
esimkowitz f5365dd
Fix clippy error
esimkowitz 141e767
Fix minimap offset
esimkowitz 56cc5ce
don't scroll horizontally, increase font weight
esimkowitz 67e0276
fix upper margin
esimkowitz 8dcbfed
Disable diagnostics for minimap
esimkowitz c606295
Fix visibility of scrollbar
esimkowitz 99e6971
fix horizontal scrollbar track width when minimap is shown
esimkowitz 8d2062a
Disable autoscroll, indent guides, and a few other features for minimap
esimkowitz 921594c
save work, adding logic for computing slider position and scroll
esimkowitz dbfe093
Got slider thumb displaying, now I just need to hook it up to the mouse
esimkowitz 4caa83a
improve positioning logic
esimkowitz ffe1d7c
remove commented code
esimkowitz 5bb7c57
Add user settings, disable mouse listeners for minimap, add mouse hover
esimkowitz 42226c4
fix too much overscrolling if minimap contents is less than height
esimkowitz e56731e
clicking on the minimap navigates to the intended section
esimkowitz 6b625a1
dragging now works too
esimkowitz b638eb1
remove conflicting delay in hiding slider
esimkowitz 0aa9ea1
fix regression in hide_minimap_slider
esimkowitz 8211776
update default.json to indicate default slider value
esimkowitz 01209d7
Merge branch 'main' into evan/minimap
esimkowitz 561ffef
address comments
esimkowitz e763ca8
fix improper percent completion calculation when dragging slider thumb
esimkowitz a475858
hook up font_size setting
esimkowitz 002ca4c
clean up variable naming
esimkowitz 81856e3
fix minimap height calculation
esimkowitz d03ae42
Apply latest changes from main
MrSubidubi c200fec
Merge pull request #1 from MrSubidubi/apply-merge-changes
esimkowitz 902670f
rename slider to thumb
esimkowitz ba71562
set thumb visibility default to always
esimkowitz ab49a2a
fix bad replace all typo
esimkowitz 7db7b0f
Merge branch 'main' into evan/minimap
esimkowitz 8c783c0
Attempt to fix vim conflict
esimkowitz 490c0f5
fix editor width bug when minimap is not visible
esimkowitz 5d8253e
Merge branch 'main' into evan/minimap
esimkowitz fb06d23
Fix minimap auto visibility
esimkowitz 8f4be66
Merge branch 'main' into evan/minimap
esimkowitz 016f0e6
fix set_cursor_style regression from merge
esimkowitz 6f3bcd8
fix soft wrapping behavior in minimap
esimkowitz fff93b0
Merge branch 'main' into minimap-tests
MrSubidubi 7e310d1
Idea for minimap scroll
MrSubidubi 9663025
Some cleanup, fix scroll for this method
MrSubidubi 4513c08
save
esimkowitz 6ae7d2f
Merge branch 'main' into evan/minimap
esimkowitz 4de58be
Merge branch 'evan/minimap' into minimap-scroll
esimkowitz 4a1261b
Merge branch 'main' into evan/minimap
esimkowitz 8d1a198
make scrollbarlayoutinformation a ref
esimkowitz 95d3cd7
Cache display map
MrSubidubi e5628ca
Disable gutter in minimap
MrSubidubi 8cf2ec3
Merge pull request #4 from MrSubidubi/disable-line-gutter
esimkowitz 0427841
fix unsigned subtract panic
esimkowitz 973c159
add back minimap width calculation
esimkowitz ded03cc
Merge branch 'evan/minimap' into display-map-clone
esimkowitz baffaad
clean up var names
esimkowitz 4d6baba
Reuse some more
MrSubidubi 23ac3f4
Merge branch 'main' into evan/minimap
esimkowitz dcd4f63
missed fixes
esimkowitz 2a1c041
clean up rem_size
esimkowitz b60fcfd
Merge branch 'evan/minimap' into display-map-clone
esimkowitz 3eae29f
Merge branch 'display-map-clone' of github.com:MrSubidubi/zed into di…
esimkowitz b559d24
Wrapping works - rework approach
MrSubidubi 67af4aa
Add `is_minimap`, some cleanup
MrSubidubi c06731e
Hm, Clippy....
MrSubidubi 7525231
Use font-size instead of em-advance
MrSubidubi 9465dbc
Remove mode change
MrSubidubi e5a0cdf
Merge pull request #3 from MrSubidubi/display-map-clone
esimkowitz f55d411
Merge branch 'main' into evan/minimap
esimkowitz 9962ad0
Some cleanups
MrSubidubi ff438e3
Disable diagnostic underlines in minimap
MrSubidubi 4aa6c06
Revert accidental change
MrSubidubi b75ffbb
Clippy
MrSubidubi 745cb7a
Remove minimap check
MrSubidubi b750ee7
Minimize Changes to `rem_size`
MrSubidubi 2ed7f86
Consider minimap width for editor soft wrap
MrSubidubi a39a288
Clean up some more
MrSubidubi abb4d7f
Also consider forcefully disabled scrollbar
MrSubidubi d4752da
Fix Vim-test
MrSubidubi 7f02733
Fix various scrolling issues
MrSubidubi 512ca9a
Only consider minimap for editor width when editor has a minimap
MrSubidubi 932a968
Disable editor serialization for minimap
MrSubidubi dbeef58
Clone `display_map` of associated editor
MrSubidubi 920b19c
Small fixes
SomeoneToIgnore 9374267
Merge branch 'main' into kb/mimimap
SomeoneToIgnore 1e161d1
Show selections and other background highlights inside the minimap
SomeoneToIgnore a231c25
Merge pull request #5 from zed-industries/kb/mimimap
MrSubidubi e43e2d6
Resolve conflicts
MrSubidubi fa4c67b
Add a way to programmatically disable the minimap
MrSubidubi 40644c4
Fix an issue where space for the scrollbar was reserved even when scr…
MrSubidubi a199290
Stop hover events from propagating
MrSubidubi ac52140
Fade out minimap background color
MrSubidubi c240e06
Add small drop shadow
MrSubidubi a7a9023
Naively enable scrolling on minimap even if clicking outside of the t…
MrSubidubi b122cad
Add `thumb_border` setting to specify how a thumb should be rendered.
MrSubidubi eb1c371
Fix scroll flickering whilst typing on the longest line
MrSubidubi 2fac6df
Swap scrollbar <-> minimap paint order
MrSubidubi e422f4e
Another batch of scrolling fixes
MrSubidubi 865c5d1
Cleanup some methods
MrSubidubi 7362afd
Improve placement of some controls
MrSubidubi ec9b54d
Consider minimap width for edit prediction popovers as well
MrSubidubi e648c11
Paint git row line highlights in the minimap
MrSubidubi 1329d6d
Make minimap editor read-only
MrSubidubi e8ee3b2
Disable rendering of blocks in the minimap for now
MrSubidubi 4bfa409
Merge branch 'main' into evan/minimap
MrSubidubi b4aa1f1
Prevent any buttuns from being layouted and rendered behind the minimap
MrSubidubi 1898646
Re-enable rendering of blocks in the minimap, add more granular control
MrSubidubi 33233b0
Add setting for highlighting the current line in the minimap
MrSubidubi 54503f2
Remove minimap font size setting
MrSubidubi 1813bc8
Remove minimap width setting
MrSubidubi d32eb7b
Fix various soft break issues
MrSubidubi 57685a6
Merge branch 'main' into evan/minimap
MrSubidubi 2bbb2ed
Resolve conflicts
MrSubidubi 13893f7
Do not render the minimap if it would take up most of the available e…
MrSubidubi f7a3f69
Do not pass scroll position a reference
MrSubidubi fa423dc
Ensure layouting stays the same as before
MrSubidubi fe537d2
Make current line highlight inherit editor line highlight by default
MrSubidubi b574129
Disable addon registering for the minimap
MrSubidubi 83c6dca
Update `current_line_highlight` setting, stop storing minimap setting…
MrSubidubi 49cd65b
Merge branch 'main' into evan/minimap
MrSubidubi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
save work
- Loading branch information
commit ca33b7be73e49f72028881a5dc8e7bc4782135f9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.