assistant_slash_commands: Be more precise in content type matching #29124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
cla-bot
bot
added
the
cla-signed
This comment was marked as resolved.
This comment was marked as resolved.
maxdeviant
changed the title
evaporei
force-pushed
the
assistant-slash-commands/content-type-fix
branch
from
9336a04 to
2a5fa48
Compare
|
Thanks! |
JosephTLyons
pushed a commit
that referenced
this pull request
May 6, 2025
…29124) While investigating #28076, I found out often times the content type header of a website comes with more data, such as the `charset`. So instead of doing an equal comparison, I changed to a `starts_with`. You can see an example here: ```shell $ curl -sS -D - https://github.com/zed-industries/zed/blob/main/Cargo.toml -o /dev/null | head -n 10 HTTP/2 200 date: Sun, 20 Apr 2025 10:19:52 GMT content-type: text/html; charset=utf-8 vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame,Accept-Encoding, Accept, X-Requested-With etag: W/"92dabf048b34d04a1b1d94e29cae4aca" cache-control: max-age=0, private, must-revalidate strict-transport-security: max-age=31536000; includeSubdomains; preload x-frame-options: deny x-content-type-options: nosniff x-xss-protection: 0 ``` Release Notes: - Improved Content Type matching of `/fetch` commands in Assistant Co-authored-by: Peter Tripp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #28076, I found out often times the content type header of a website comes with more data, such as the
charset. So instead of doing an equal comparison, I changed to astarts_with.You can see an example here:
Release Notes:
/fetchcommands in Assistant