Skip to content

agent: Improve terminal tool card design #29712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 5, 2025
Merged

agent: Improve terminal tool card design #29712

merged 9 commits into from
May 5, 2025

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 30, 2025 •
edited
Loading

To-dos:

  • Expose the command to defend against cases where that's just super long
  • Tackle the vertical scroll conflict with panel scroll
  • Reduce default font-size

Release Notes:

  • agent: Improved the terminal rendering in the Agent Panel by fixing panel vs. card scrolling conflict, better exposing the command input, and adjusting font-size to match the other text elements.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 30, 2025
danilo-leal and others added 8 commits May 1, 2025 21:08
@danilo-leal
Merge remote-tracking branch 'origin/main' into ag-terminal-tool-desi…
7a767a8 
…gn-tweaks
@danilo-leal
Merge remote-tracking branch 'origin/main' into ag-terminal-tool-desi…
308ffeb 
…gn-tweaks
@danilo-leal @benbrandt
Remove unnecessary rounding on the edit file tool
e63dd3b 
Co-authored-by: Ben Brandt <[email protected]>
@danilo-leal @benbrandt
Polish terminal card header
300ec2a 
Co-authored-by: Ben Brandt <[email protected]>
@danilo-leal @benbrandt
Polish out truncated label
38af1e5 
Co-authored-by: Ben Brandt <[email protected]>
@benbrandt
Fix typo for returning the terminal view
af66cc3
@mikayla-maki @benbrandt @agu-z
Fix double-scroll in the terminal tool, and align behavior with Cursor
4e2c82a 
(only scrolling when the terminal is focused)

Co-authored-by: Ben Brandt <[email protected]>
Co-authored-by: Agus Zubiaga <[email protected]>
@mikayla-maki @benbrandt @agu-z
Fix terminal font size when rendered in an embedded context
e0d84aa 
Co-authored-by: Ben Brandt <[email protected]>
Co-authored-by: Agus Zubiaga <[email protected]>
@benbrandt benbrandt enabled auto-merge (squash) May 5, 2025 17:50
@benbrandt benbrandt merged commit 7dfbe0b into main May 5, 2025
21 checks passed
@benbrandt benbrandt deleted the ag-terminal-tool-design-tweaks branch May 5, 2025 18:50
JosephTLyons pushed a commit that referenced this pull request May 5, 2025
@danilo-leal @benbrandt
@mikayla-maki @agu-z @JosephTLyons
agent: Improve terminal tool card design (#29712)
b65b251 
To-dos:

- [x] Expose the command to defend against cases where that's just super
long
- [x] Tackle the vertical scroll conflict with panel scroll
- [x] Reduce default font-size

Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <[email protected]>
Co-authored-by: Mikayla Maki <[email protected]>
Co-authored-by: Agus Zubiaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danilo-leal @benbrandt @mikayla-maki