-
Notifications
You must be signed in to change notification settings - Fork 4.6k
language_models: Add tool use support for Mistral models #29994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implement tool use handling in Mistral provider, including mapping tool call events and updating request construction. Add support for tool_choice and parallel_tool_calls in Mistral API requests.
Hey @notpeter thanks for testing, can you help me with the which model did you try this with. I am currently unable to reproduce this at the mode. Will see if I am able to do it with the specific model. |
It was with |
@notpeter I think the last mistral-medium should be a lot more reliable. I have very good results with other agentic tools such as Cline or Aider.dev |
One thing that i do not love is that I tried the de-duping (filter out duplicate ids, non chat models and de-dup by name) but still end up with a lot of unnecessary models that i'm not interested in using: Screen.Recording.2025-05-15.at.10.51.22.mov |
Hey @bennetbo got it. I guess in my case it was less so I didn't see this issue. In that case i can revert model fetch and have a hardcoded models in this pr. Probably we can discuss a better approach for exposing all models as a part of seperate pr wdyt? |
Sounds good 👍🏻 |
Maybe only |
Hey @bennetbo , I have removed the code changes for fetching the model dynamically. Also I have added the demo-mistral.mov |
Current best mistral agentic model is mistral medium latest actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #29855
Implement tool use handling in Mistral provider, including mapping tool call events and updating request construction. Add support for tool_choice and parallel_tool_calls in Mistral API requests.
This works fine with all the existing models. Didn't touched anything else but for future. Fetching models using their models api, deducting tool call support, parallel tool calls etc should be done from model data from api response.
Tasks:
Release Notes: