Skip to content

Fix agent reading and editing files over SSH #30144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2025
Merged

Fix agent reading and editing files over SSH #30144

merged 5 commits into from
May 7, 2025

Conversation

as-cii
Copy link
Member

@as-cii as-cii commented May 7, 2025

Release Notes:

  • Fixed a bug that would prevent the agent from working over SSH.

as-cii and others added 3 commits May 7, 2025 17:33
@as-cii @nathansobo @rtfeldman
Remove deprecated {create,edit}_file_tool
1dcf138 
Co-authored-by: Nathan Sobo <[email protected]>
Co-authored-by: Richard Feldman <[email protected]>
@as-cii @nathansobo @rtfeldman
Use buffer's disk state to assess file existence
d7b547c 
Co-authored-by: Nathan Sobo <[email protected]>
Co-authored-by: Richard Feldman <[email protected]>
@as-cii @rtfeldman
Add test for file existence when using edit_file
e9669d3 
Co-authored-by: Richard Feldman <[email protected]>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 7, 2025
as-cii and others added 2 commits May 7, 2025 18:31
@as-cii @maxbrunsfeld
@rtfeldman @cole-miller
Fix formatting
61a37d7 
Co-authored-by: Max Brunsfeld <[email protected]>
Co-authored-by: Richard Feldman <[email protected]>
Co-authored-by: Cole Miller <[email protected]>
@as-cii @maxbrunsfeld
@rtfeldman @cole-miller
Fix tests
495af40 
Co-authored-by: Max Brunsfeld <[email protected]>
Co-authored-by: Richard Feldman <[email protected]>
Co-authored-by: Cole Miller <[email protected]>
@as-cii as-cii enabled auto-merge (squash) May 7, 2025 16:50
@as-cii as-cii merged commit 89430a0 into main May 7, 2025
19 checks passed
@as-cii as-cii deleted the fix-file-exists branch May 7, 2025 17:07
notpeter pushed a commit that referenced this pull request May 7, 2025
@as-cii @nathansobo
@rtfeldman @maxbrunsfeld @cole-miller @notpeter
Fix agent reading and editing files over SSH (#30144)
3cabcd7 
Release Notes:

- Fixed a bug that would prevent the agent from working over SSH.

---------

Co-authored-by: Nathan Sobo <[email protected]>
Co-authored-by: Richard Feldman <[email protected]>
Co-authored-by: Max Brunsfeld <[email protected]>
Co-authored-by: Cole Miller <[email protected]>
notpeter pushed a commit that referenced this pull request May 7, 2025
@as-cii @nathansobo
@rtfeldman @maxbrunsfeld @cole-miller @notpeter
Fix agent reading and editing files over SSH (#30144)
13743ef 
Release Notes:

- Fixed a bug that would prevent the agent from working over SSH.

---------

Co-authored-by: Nathan Sobo <[email protected]>
Co-authored-by: Richard Feldman <[email protected]>
Co-authored-by: Max Brunsfeld <[email protected]>
Co-authored-by: Cole Miller <[email protected]>
lj3954 pushed a commit to lj3954/zed that referenced this pull request May 9, 2025
@as-cii @nathansobo
@rtfeldman @maxbrunsfeld @cole-miller @lj3954
Fix agent reading and editing files over SSH (zed-industries#30144)
587406a 
Release Notes:

- Fixed a bug that would prevent the agent from working over SSH.

---------

Co-authored-by: Nathan Sobo <[email protected]>
Co-authored-by: Richard Feldman <[email protected]>
Co-authored-by: Max Brunsfeld <[email protected]>
Co-authored-by: Cole Miller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@as-cii