Skip to content

Reuse conversation cache when streaming edits #30245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025
Merged

Reuse conversation cache when streaming edits #30245

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d25cf8a
Avoid caching messages with pending tool uses
as-cii May 8, 2025
f2a3934
:art:
as-cii May 8, 2025
3842e25
Move cache back by one message when removing pending
as-cii May 8, 2025
f2bd33f
Provide the entire conversation to `Tool`
as-cii May 8, 2025
8f41bd9
Specify tools when streaming edits but tell the model not to call them
as-cii May 8, 2025
f17721c
Checkpoint
as-cii May 8, 2025
93a9ed7
Avoid re-including tools if `tool_choice` is not supported
as-cii May 8, 2025
86f1be5
Stop logging the raw edits
as-cii May 8, 2025
0be89fa
Don't run eval by default
as-cii May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stop logging the raw edits
  • Loading branch information
@as-cii
as-cii committed May 8, 2025
commit 86f1be5c0325da1ddb71cc495d9d552968a461f7
3 changes: 1 addition & 2 deletions crates/assistant_tools/src/edit_file_tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,7 @@ impl Tool for EditFileTool {
EditAgentOutputEvent::OldTextNotFound(_) => hallucinated_old_text = true,
}
}
let output = output.await?;
println!("{}", output._raw_edits);
output.await?;

project
.update(cx, |project, cx| project.save_buffer(buffer.clone(), cx))?
Expand Down
Loading