Fix make file #7
Conversation
Use gh-pages branch as master does not exist Add VERSION to use src files that exist Add a PORT var in case it needs to run on another port
|
This doesn't look equivalent to me but I never really used the |
|
I hadn't had a chance to update this in a while. So glad you took the time to fix for me ✨ |
| @rm -f javascript/ZeroClipboard* | ||
| @mv ZeroClipboard.* javascripts/ | ||
| @cp javascripts/zc/ZeroClipboard_$(VERSION).js javascripts/ZeroClipboard.js | ||
| @cp javascripts/zc/ZeroClipboard_$(VERSION).swf javascripts/ZeroClipboard.swf |
There was a problem hiding this comment.
oh, this might be some confusion. what the original intent was, when the gh-pages and the code were on the same repo, I would checkout master to get the newly compiled swf and js.
So this now, instead of checking out the branch on the current repo, would need to get the new files @ a tag version or master from the github.com/zeroclipboard/zeroclipboard repo.
|
@jonrohan thanks for letting me know what the functionality was. It now downloads a tag with curl. It won't download master as the URL won't match but this works for now. :) |
|
awesome 🤘 |
|
This still isn't quite right.
|
|
ooops, I've got an itchy merging finger. |
Use gh-pages branch as master does not exist
Add VERSION to use src files that exist
Add a PORT var in case it needs to run on another port
This seems to run OK now.