Compilation: add missing link file options to cache manifest #23921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
approved these changes
May 29, 2025
|
I'll take that, I certainly don't think it can cause any issues. I'll try and double check that it actually fixes the issue (I barely tested this locally lol) and merge if all is well. |
mlugg
force-pushed
the
link-file-options-cache-manifest
branch
from
336fbe0 to
7cf04d6
Compare
|
Rebased, and tested the |
Also add a standalone test which covers the `-fentry` case. It does this by performing two reproducible compilations which are identical other than having different entry points, and checking whether the emitted binaries are identical (they should *not* be). Resolves: ziglang#23869
mlugg
force-pushed
the
link-file-options-cache-manifest
branch
from
7cf04d6 to
998b7a0
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unintentionally closed #23891 while pruning branches; this is the exact same diff.
Resolves: #23869