windows: msvc: avoid depending on ucrtbased.dll by statically linking to ucrt in debug mode #24207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather we only avoid linking |
|
@alexrp I think that's a reasonable position, I also considered this solution and didn't have a strong opinion that one was better than the other. I'll let you be the "tie breaker" and I'll update the PR with your suggested variation. |
marler8997
force-pushed
the
msvcStaticUcrt
branch
from
91ede99 to
8d239b4
Compare
marler8997
changed the title
alexrp
reviewed
Jun 19, 2025
marler8997
force-pushed
the
msvcStaticUcrt
branch
from
8d239b4 to
95edb3c
Compare
alexrp
reviewed
Jun 19, 2025
marler8997
force-pushed
the
msvcStaticUcrt
branch
from
95edb3c to
ac0855b
Compare
alexrp
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug builds, this change updates all cmake targets to statically link to the "Universal C Runtime Library" (ucrt) by default. This adds about 1 to 2 megabytes but also removes th runtime dependency on
ucrtbased.dll, which is only available on machines that have installed the Windows SDK (and added the ucrtbased.dll parent directory to the systemPATHenvironment variable).