micro: Handle +/text search text from args #3767
Conversation
There was a problem hiding this comment.
I think NewBufferFromFileWithCommand is a weird API to have because it's coupled to how the CLI works. It also requires changing all the call sites. Do you think it would be feasible to keep NewBufferFromFileAtLoc/NewBuffer as-is and handle moving the cursor to a match separately?
|
That's possible, but it's not that different from the current API as a whole, it would be equivalent to simply adding searchText parameter (as start location was only used for CLI already) And if I split open & match i'd be weird to handle the save cursor option and furthermore the onBufferOpen would run before finding matches, and now you'd have start position (either from +lin:col for filename), onBufferOpen and then match, it would be very confusing to me... Feel free to propose something, but this seemed the "sanest" model to implement to me |
That was my first though too, but after a closer look, it looks like quite a sane generalization of
Potentially we might use this concept of "command" not just in the CLI but also in some other cases at runtime, like it is used in vim (and vi, ed, sed...). |
luca020400
force-pushed
the
luca/plusslash
branch
2 times, most recently
from
d850c9a to
71aa1ec
Compare
This is a feature found in vim and commonly used by Linux kernel test robots to give context about warnings and/or failures. e.g. vim +/imem_size +623 drivers/net/ipa/ipa_mem.c The order in which the commands appear in the args determines in which order the "goto line:column" and search will be executed.
luca020400
force-pushed
the
luca/plusslash
branch
from
71aa1ec to
6c4fdf7
Compare
This is a feature found in vim and commonly used
by Linux kernel test robots to give context about
warnings and/or failures.
e.g. vim +/imem_size +623 drivers/net/ipa/ipa_mem.c
The order in which the commands appear in the args
determines the order in which the "goto line:column"
and search text will be executed.