xcircuit-dev Mailing List for XCircuit

Dear Massimo,
   As I suspected, the innocuous-seeming highlighted network was, in
fact, a very bad bug.  It is important to tag the netlist as invalid
whenever a potential change occurs, but I missed doing the invalidation
on an "import" function.  I'm surprised that you got a correct netlist
out of the "write spice" function.  But the behavior might just be more
subtle than I expect.
   The solution is to add the following line at files.c:line 1201:

      /* good so far;  let's clear out the old data structure */
      topobject->valid = False;

Which forces any existing netlist to be declared invalid.

   The "Error: duplicate part number" message is at netlist.c:line 2131
and can be commented out if it bothers you.  I'll see if I can find
some test to distinguish between the "real" and the "apparant" errors.

						Regards,
						Tim

Dear Massimo,

   The message "Error: duplicate part number X and X" is an unfortunate
artifact of the parameterization code that deals with parts like those
in the "quadparts" library.  The code that's supposed to catch duplicate
part numbers ends up spending most of its time complaining about things
that aren't real errors.

> ... the net connecting R6 to the Gnd symbol is now highlighted in
> green colour.

That shouldn't happen without executing a "highlight connectivity"
command; I'll take a look at it.

					Regards,
					Tim

Dear Jim,

I observed exactly the same behaviour. I am using Slackware 8.0 and the 
fvwm2 window manager.

Because I am not able to reproduce this problem I have not submitted the
bug report to Tim.

I compiled the 3.0 version (latest) with

  --disable-focus-fix

that avoid crashes iconifying the window.

Now I am not observing (so far) the problem, but I am not sure
to have solved it becasue I was not able to identify the failure
mechanism (may be I am lucky in these days)

Hope this helps


Massimo


Jim Whitby wrote:

> I have to believe this is my problem... but I can't see where.
> 
> None of the pull-down menus function on my machine. The menus 
> "highlight", but thats all.
> 
> If I start it with a filename from the examples. it loads fine.
> 
> I have python 2.2 installed. System is a "stock" Mandrake 8.2.
> 
> Xcircuit compiles with no errors ( ./configure --prefix=/usr )
> 
> I tried with Tk. The menus function or seem to , they at least show up.
> 
> I'm open to any suggestions.
> 
> Will supply whatever info you might request.
> 
> 
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Xcircuit-dev mailing list
> Xci...@li...
> https://lists.sourceforge.net/lists/listinfo/xcircuit-dev
> 


-- 

                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

Dear Tim and Xcircuit users,

Try this
1) Run xcircuit and "import Xcircuit PS " the attached bug#2.ps
2) do a Netlist -> Write Spice
3) You get several error messages in the stdout reading

Error: duplicate part number Rload and Rload
Error: duplicate part number Rload and Rload
Error: duplicate part number Rload and Rload
Error: duplicate part number Rload and Rload


and the net connecting R6 to the Gnd symbol is now highlighted in green 
colour.


The spice netlist seems good

I checked the circuit and I am sure that there is only one resistor
called Rload, so I am not understanding the error messages.

Because I wrote a large library with all my preferred symbols (spice
oriented) may be I introduced some strange dirty stuff.

The library is not (so far) fully checked, anyway I attached the library.

If you find it useful, or if you think that is interesting enough to
somebody, feel free to publish it in the user object library (web site)
or simply delete it :-)

Regards

Massimo

-- 

                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

I have to believe this is my problem... but I can't see where.

None of the pull-down menus function on my machine. The menus 
"highlight", but thats all.

If I start it with a filename from the examples. it loads fine.

I have python 2.2 installed. System is a "stock" Mandrake 8.2.

Xcircuit compiles with no errors ( ./configure --prefix=/usr )

I tried with Tk. The menus function or seem to , they at least show up.

I'm open to any suggestions.

Will supply whatever info you might request.

Dear Massimo,

   Thanks for the bug reports.  I've been at a conference for several
days, so your bug reports have been piling up.  Here are the results:

---------------------------------------------
1) Start xcircuit
2) Load the attached bug?.lps library
3) Go to the bug? library ('l' command)
4) Edit the symbol bug? ('>' command)
5) Select the ? (only the '?') in the info label 'spice:R?' with the 
middle mouse key
6) Go to text -> unparameterize
7) segmentation fault
---------------------------------------------

I can't get this one to crash.  I *did* make a few changes to the
"unparameterize" function code between version 2.5.4 and version
3.0 (2.5.5), so my best guess is that the problem got fixed already.

---------------------------------------------
1) run xcircuit
2) "Import Xcircuit ps" the attached example (bug.ps)
3) Go to Netlist -> Make Matching Symbol
4) Input the name of the symbol (i.e. "All")
5) Now instead to draw the symbol press "<"
6) Segmentation fault
---------------------------------------------

Ouch.
I see I missed something I was supposed to remove.
"events.c" line 398:  Remove lines 398 to 401

#ifdef SCHEMA
   if (xobjs.stack->thisinst->thisobject->symschem == topobject)
      pop_stack(&xobjs.stack);
#endif

and the problem will go away.  However, the same change I made which
made those two lines necessary also produces the strange behavior that
when you go from a top page to the library, then edit (">") the library
object, the page appears drawn in gray as if you pushed from the page
and not the library.  I'll have to find a fix, although the problem is
minor.

---------------------------------------------
1) Load the attached library pippo1.lps
2) go to the library and ">" the nMesfet
3) insert an Info pin (I) and write "spice:Z? %pd %pg %ps ?"
4) Highlight (with the middle button) the first ? and parameterize it
5) Highlight the second ? and parameterize it
6) Segmentation fault. It is reproducible
---------------------------------------------

Ouch again!
"parameter.c", line 1105.  Change:

      begpart = splitstring(textend, &thislabel->string, NULL);
      endpart = splitstring(textpos, &thislabel->string, NULL);

to

      begpart = splitstring(textend, &thislabel->string, areastruct.topinstance);
      endpart = splitstring(textpos, &thislabel->string, areastruct.topinstance);

This fixes the problems.
The fixes will be reflected in the distribution as soon as the lab's ISP
allows me to connect to the university machine again. . .  (it amazes me
that the entire internet seems to be available except for the connection
between the university and its own research laboratory!)

						Regards,
						Tim

Dear Tim,

I think to have found another strange bug (starting from now I am 
numbering my bug reports, this is #1 :-) )

Case 1) Using: Xcircuit 3.0 dated 8 Jul 2002 + patch for Python 
(PyRun_StringFlags (...) ), compiled with
./configure --disable-focus-fix
make
make install

1) Load the attached library pippo1.lps
2) go to the library and ">" the nMesfet
3) insert an Info pin (I) and write "spice:Z? %pd %pg %ps ?"
4) Highlight (with the middle button) the first ? and parameterize it
5) Highlight the second ? and parameterize it
6) Segmentation fault. It is reproducible

Case 2) Using Xcircuit 2.5 from Slackware package downloaded from your site

This bug is not present.

Case 3) Compiling like in Case1 without --disable-focus-fix

exactly identical to Case 1)


Case 4)

Running the debugger (xxgdb) over the executable obtained in Case3)
I get


Program received signal SIGSEGV, Segmentation Fault
[switching to Thread 1024 (LWP 5182)]
linkstring (localinst=0x0, strstart=0x8268c50) at text.c:310

The line 310 of text.c is
310: if (localinst->thisobject->params[paramno]->type != XC_STRING) {
311:      fprintf(stderr, "linkstring() error: parameter %d is not a 
               substring!\n",
312:         paramno);
313      return strstart->nextpart;
314   }

I haven't the source code of the 2.5 version, so I cannot compare the 
differences. Anyway the error message (line 311:) is not printed on stderr.


I hope you will able to get the error (bug).

Hope this helps.

Massimo



-- 

                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

Dear Tim and xcircuit users,

Try this

1) run xcircuit
2) "Import Xcircuit ps" the attached example (bug.ps)
3) Go to Netlist -> Make Matching Symbol
4) Input the name of the symbol (i.e. "All")
5) Now instead to draw the symbol press "<"
6) Segmentation fault


Hope this helps

Regards

Massimo

-- 

                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

Dear Tim and Xcircuit users,

Try this.

1) Start xcircuit
2) Load the attached bug?.lps library
3) Go to the bug? library ('l' command)
4) Edit the symbol bug? ('>' command)
5) Select the ? (only the '?') in the info label 'spice:R?' with the 
middle mouse key
6) Go to text -> unparameterize
7) segmentation fault

This bug is present in my Slackware 8.0 linux station. I don't know
if the bug is present in other OS or distribution.

(Slackware 8.0 is kernel 2.2.19 glibc 2.2.3 Xcircuit 2.5.4 pre-compiled 
slackware package from Tim's site. )


Another strange behaviour

1) Start Xcircuit from a shell prompt
2) Iconify it
3) you get
X Error of failed request:  BadMatch (invalid parameter attributes)
   Major opcode of failed request:  42 (X_SetInputFocus)
   Serial number of failed request:  9390
   Current serial number in output stream:  9390

and the Xcircuit dies.

Very strange. May be relate to the X (Xfree 4.1.0 and/or  fvwm 2.5.5 
window manager).

Another issue:

As I told in my last e-mail I cannot compile the new 3.0 (8 jul) version
with python 2.0.1 due to lack of PyRun_StringsFlags symbol int the 
python library. I observed that the new Python 2.2.1 has this reference 
in the library. So definitevely I need to upgrade the Python package 
and/or toupgrade to Slackware 8.1. Anyway may be a good idea to put a 
warning in the web site about this issue, 2.0.1 is not enough! :-)
I guess that the Slackware package in the web site was not compiled 
under pure Slackware 8.0 (that has python 2.0.1), it is impossible.

Hope this helps


Regards

Massimo






-- 

                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

Dear Tim and xcircuit users,

I am trying to compile the new 3.0 version (8 jul) but I am unable (so 
far) to get an working executable.

I am compiling under Slackware 8.0 with Phyton 2.0.1,
Tcl/Tk 8.3.3 installed and Tclx 8.3.0 installed.


Compiling after a

./configure
make

I get

gcc  -O2 -L/usr/X11R6/lib -L/usr/lib/python2.0/config -o xcircuit 
elements.o events.o filelist.o files.o fontfile.o formats.o functions.o 
help.o keybindings.o libraries.o menucalls.o netlist.o parameter.o 
python.o rcfile.o render.o schema.o selection.o text.o wrapper.o 
tkSimple.o xcircuit.o Xw/libxcXw.a -lXt -lm  -lpython2.0 
  -lpthread -ldl  -lutil          -lm -lXpm -lX11
/usr/lib/python2.0/config/libpython2.0.a(posixmodule.o): In function 
`posix_tmpnam':
posixmodule.o(.text+0x25fe): the use of `tmpnam_r' is dangerous, better 
use `mkstemp'
/usr/lib/python2.0/config/libpython2.0.a(posixmodule.o): In function 
`posix_tempnam':
posixmodule.o(.text+0x255a): the use of `tempnam' is dangerous, better 
use `mkstemp'
python.o: In function `PyRun_ObjString':
python.o(.text+0x33): undefined reference to `PyRun_StringFlags'
collect2: ld returned 1 exit status
make[1]: *** [xcircuit] Error 1
make[1]: Leaving directory `/user/gaspari/compile/xcircuit-3.0'
make: *** [all-recursive] Error 1


Compiling after a

./configure --enable-wrapper
make wrapper

I get

swig -tcl8 -o xcwrap.c xcwrap.i
make: swig: Command not found
make: *** [xcwrap.c] Error 127

I loooked in all the installed packaged, I have not found the
required 'swig'.

I never used Tcl/Tk so I will try to understand what is the required 
swig executable.

In the first case I guess that you are using a new version of Python.
Really the 'PyRun_StringFlags' is not defined in my libpython2.0.a

Doing a nm libpython2.0.a I get the 'PyRun_String' reference but not the

PyRun_StringFlags

I have attached the two config.log files.

I will try to understand more details tomorrow.

In addition I am reporting a compilation warning too

gcc -DPACKAGE=\"xcircuit\" -DVERSION=\"3.0\" -DPROTOTYPES=1 
-DHAVE_LIBM=1 -DHAVE_LIBXT=1 -DSTDC_HEADERS=1 -DHAVE_SETENV=1 
-DHAVE_PUTENV=1 -DHAVE_DIRENT_H=1 -DHAVE_U_CHAR=1 -DSCHEMA=1 
-DSCHEM_FLAG=\"-schema\" -DLGF=1 -DINPUT_FOCUS=1 -DGS_EXEC=\"gs\" 
-DHAVE_PYTHON=1 -DHAVE_X11_XPM_H=1 -DHAVE_XPM=1  -I. -I.  -IXw 
-DPROG_VERSION=3.0 -DTEMP_DIR=\"/tmp\" 
-DRESOURCES_DIR=\"/usr/local/share/xcircuit-3.0/app-defaults\" 
-DBUILTINS_DIR=\"/usr/local/share/xcircuit-3.0\" -DBUILTINS_FILE=\"\" 
-DUSER_RC_FILE=\".xcircuitrc\" 
-DPROLOGUE_DIR=\"/usr/local/share/xcircuit-3.0\" 
-DPROLOGUE_FILE=\"xcircps2.pro\" -DSTARTUP_FILE=\"xcstartup.py\" 
-DCONFIG_FILE=\"\" -DLGF_LIB=\"lgf.lps\"  -I/usr/X11R6/include 
-DDOUBLEBUFFER -I/usr/include/python2.0  -g -O2 -c python.c
python.c: In function `PyRun_ObjString':
python.c:149: warning: assignment makes pointer from integer without a cast


Hope this helps.

Regards

Massimo


-- 


                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

Dear all,

In my last bug report I wrote some key combination using bracket. The 
web interface of the sourceforge repository has trouble with this. Some 
characters are disappeared. So I repost in a different way two lines of 
my last e-mail


.
.
.
.
6) Go to the end of the string (after the parameter ?) and out of the 
angle bracket and press Alt+Enter

7) Press Alt+P and then "2" to add the second parameter (the model)
.
.
.


Sorry for the time waste.

Bye

Massimo


-- 

                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

Dear Massimo,

    There are effectively no differences between xcircuit-2.5.4 and
xcircuit-3.0; the difference between the two versions is some
experimental Tcl/Tk code that is not compiled by default.

    So, anyway, the bug you found is that the parameter numbers shown
for selection when you use "alt-P" are wrong; the routine counts only
the string parameters (not the numerical parameters), but forgot to
add them to the parameter count when mapping the selection number
back to the parameter number.  Consequently, you get a numerical
parameter inserted into the string, causing a core dump.

    Attached is a patch file which cures the problem.  Thanks for the
detailed bug report.

						Regards,
						Tim

+--------------------------------+-------------------------------------+
| Dr. R. Timothy Edwards (Tim)   | email: ti...@st...    |
| Mailstop 4-234 (SRI)           | web:   http://bach.ece.jhu.edu/~tim |
| JHU Applied Physics Laboratory | phone: (240) 228-4613               |
| 11100 Johns Hopkins Road       | fax:   (240) 228-7636               |
| Laurel, MD  20723-6099         | cell:  (240) 461-3895               |
+--------------------------------+-------------------------------------+

Dear Tim and Xcircuit users,

May be I found a bug in Xcircuit (version 2.5.4 Slackware 8.0 libc 2.2.1 
  kernel 2.2).


1) "Load new library" the attached "pippo.lps"

2) go to the library page "pippo"

3) Look at the NPN

4) Put the cursor on it and press ">" to edit the symbol

5) put the cursor on the text label "Q?" and press "e" to edit

6) Go to the end of the string (after the parameter ?) and out of the <> 
and press <Alt-Enter>

7) Press <Alt-P> and then "2" to add the second parameter (the model)

8) Segmentation Fault

Is the 3.0 affected?

I haven't applied, so far, the patch for the "more than 9 parameters 
problem" reported few days ago.

For the future I will compile Xcircuit with the -g option.
So my reports will be clearer attaching stuff from the gnu debugger.

Hope this helps

Regards

Massimo


-- 

                          ''~``
                         ( o o )
+------------------.oooO--(_)--Oooo.------------------+
|                                                     |
|          e-mail:  address ga...@ti...            |
|          PGP key available on keyserver             |
|PGP fingerprint16:                                   |
|  76 80 F2 F9 8D 70 F3 D1  42 2B CD 80 29 49 CB 25   |
|                                                     |
|                    .oooO                            |
|                    (   )   Oooo.                    |
+---------------------\ (----(   )--------------------+
                        \_)    ) /
                               (_/

Dear Massimo,

   Oops, typo!  I guess I never made a part with more than 9 parameters
before, because the file reader will only look at the last digit.  The
fix is to change one word in files.c (in version 3.0, it's line 2772; it
may be a few line numbers different in version 2.5.4):

Change:

         else if (!strcmp(keyword, "beginparm")) { /* parameterized object */
            short tmpnum, i;
            for (--keyptr; *keyptr == ' '; keyptr--);
            for (; isdigit(*keyptr) && (keyptr >= lineptr); keyptr--); 
                                                  ^^^^^^^

to:

         else if (!strcmp(keyword, "beginparm")) { /* parameterized object */
            short tmpnum, i;
            for (--keyptr; *keyptr == ' '; keyptr--);
            for (; isdigit(*keyptr) && (keyptr >= buffer); keyptr--); 
                                                  ^^^^^^

Thanks for the detailed bug report.  It made it very easy to track down
the source of the problem.
						Regards,
						Tim