Re: Default make target in test modules

Tom Lane wrote:
> I happened to notice that if you type "make" in
> src/test/modules/test_pg_dump, you will get a "make check" action
> not "make all". I hope this is just somebody being thoughtless
> about Makefile ordering and not an intentional override of the
> default make target. If the latter, I beg to differ about it
> being a good idea.

Strange. Don't all these makefiles depend on the pgxs stuff emitting
something sane, which would have "all" as the first one? ... Ooh, I see
that test_pg_dump adds "check" before including pgxs, which is what
AFAICS causes the problem.

I suppose this is a very easy mistake to make -- but also fortunately an
easy one to correct. Do you want me to fix the affected modules?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services