pgsql: Improve placement of "display name" comment in win32_tzmap[] ent

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve placement of "display name" comment in win32_tzmap[] ent
Date: 2020-04-24 21:53:52
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve placement of "display name" comment in win32_tzmap[] entries.

Sticking this comment at the end of the last line was a bad idea: it's
not particularly readable, and it tempts pgindent to mess with line
breaks within the comment, which in turn reveals that win32tzlist.pl's
clean_displayname() does the wrong thing to clean up such line breaks.
While that's not hard to fix, there's basically no excuse for this
arrangement to begin with, especially since it makes the table layout
needlessly vary across back branches with different pgindent rules.
Let's just put the comment inside the braces, instead.

This commit just moves and reformats the comments, and updates
win32tzlist.pl to match; there's no actual data change.

Per odd-looking results from Juan José Santamaría Flecha.
Back-patch, since the point is to make win32_tzmap[] look the
same in all supported branches again.

Discussion: https://postgr.es/m/[email protected]

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3f3ab184c642ecdb79975d2ee567a669df5245a8

Modified Files
--------------
src/bin/initdb/findtimezone.c | 441 +++++++++++++++++++++++++++---------------
src/tools/win32tzlist.pl | 14 +-
2 files changed, 292 insertions(+), 163 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-04-25 00:31:14 Re: pgsql: Fix handling of WAL segments ready to be archived during crash r
Previous Message Tom Lane 2020-04-24 19:51:52 pgsql: Doc: update section 9.13 for new function table layout.