pgsql: Really fix the ambiguity in REFRESH MATERIALIZED VIEW CONCURRENT

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Really fix the ambiguity in REFRESH MATERIALIZED VIEW CONCURRENT
Date: 2021-08-07 17:30:07
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Really fix the ambiguity in REFRESH MATERIALIZED VIEW CONCURRENTLY.

Rather than trying to pick table aliases that won't conflict with
any possible user-defined matview column name, adjust the queries'
syntax so that the aliases are only used in places where they can't be
mistaken for column names. Mostly this consists of writing "alias.*"
not just "alias", which adds clarity for humans as well as machines.
We do have the issue that "SELECT alias.*" acts differently from
"SELECT alias", but we can use the same hack ruleutils.c uses for
whole-row variables in SELECT lists: write "alias.*::compositetype".

We might as well revert to the original aliases after doing this;
they're a bit easier to read.

Like 75d66d10e, back-patch to all supported branches.

Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d33fc411000e197bc77b7b4a9010738b460c670d

Modified Files
--------------
src/backend/commands/matview.c | 51 ++++++++++++++++++++---------------
src/test/regress/expected/matview.out | 10 ++++++-
src/test/regress/sql/matview.sql | 10 ++++++-
3 files changed, 47 insertions(+), 24 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-08-07 17:37:16 Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
Previous Message Andres Freund 2021-08-07 17:25:56 Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o