pgsql: Avoid naming conflict between transactions.sql and namespace.sql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid naming conflict between transactions.sql and namespace.sql
Date: 2023-05-19 14:57:58
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table. (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b973f93b6c540f65c960bfb19af55f3d4afe4b72

Modified Files
--------------
src/test/regress/expected/transactions.out | 76 +++++++++++++++---------------
src/test/regress/sql/transactions.sql | 64 ++++++++++++-------------
2 files changed, 70 insertions(+), 70 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2023-05-19 15:18:40 pgsql: Allocate hash join files in a separate memory context
Previous Message Peter Eisentraut 2023-05-19 14:24:06 pgsql: Remove stray mid-sentence tabs in comments