pgsql: Avoid recursion in MemoryContext functions

From: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid recursion in MemoryContext functions
Date: 2024-03-08 11:19:14
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid recursion in MemoryContext functions

You might run out of stack space with recursion, which is not nice in
functions that might be used e.g. at cleanup after transaction
abort. MemoryContext contains pointer to parent and siblings, so we
can traverse a tree of contexts iteratively, without using
stack. Refactor the functions to do that.

MemoryContextStats() still recurses, but it now has a limit to how
deep it recurses. Once the limit is reached, it prints just a summary
of the rest of the hierarchy, similar to how it summarizes contexts
with lots of children. That seems good anyway, because a context dump
with hundreds of nested contexts isn't very readable.

Report by Egor Chindyaskin and Alexander Lakhin.

Discussion: https://postgr.es/m/1672760457.940462079%40f306.i.mail.ru
Author: Heikki Linnakangas
Reviewed-by: Robert Haas, Andres Freund, Alexander Korotkov, Tom Lane

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4c1973fcaecd9ef11de14ac55d3ec1432f6b82dc

Modified Files
--------------
src/backend/utils/mmgr/mcxt.c | 269 +++++++++++++++++++++++++++++-------------
src/include/utils/memutils.h | 3 +-
2 files changed, 190 insertions(+), 82 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2024-03-08 15:33:24 pgsql: Admit deferrable PKs into rd_pkindex, but flag them as such
Previous Message Heikki Linnakangas 2024-03-08 08:24:52 Re: pgsql: Unicode case mapping tables and functions.