pgsql: Fix parsing of ignored operators in websearch_to_tsquery().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix parsing of ignored operators in websearch_to_tsquery().
Date: 2024-06-14 00:35:10
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix parsing of ignored operators in websearch_to_tsquery().

The manual says clearly that punctuation in the input of
websearch_to_tsquery() is ignored, except for the special cases
of dashes and quotes. However, this failed for cases like
"(foo bar) or something", or in general an ISOPERATOR character
in front of the "or". We'd switch back to WAITOPERAND state,
then ignore the operator character while remaining in that state,
and then reach the "or" in WAITOPERAND state which (intentionally)
makes us treat it as data.

The fix is simple enough: if we see an ISOPERATOR character while in
WAITOPERATOR state, we have to skip it while staying in that state.
(We don't need to worry about other punctuation characters: those will
be consumed as though they were words, but then rejected by lexizing.)

In v14 and up (since commit eb086056f) we can simplify the code a bit
more too, because there is no longer a reason for the WAITOPERAND
state to distinguish between quoted and unquoted operands.

Per bug #18479 from Manos Emmanouilidis. Back-patch to all supported
branches.

Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/56a8296212b68267dc2bddeb1fb40a893b1aadb3

Modified Files
--------------
src/backend/utils/adt/tsquery.c | 22 +++++++++-------------
src/test/regress/expected/tsearch.out | 7 +++++++
src/test/regress/sql/tsearch.sql | 3 +++
3 files changed, 19 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2024-06-14 01:09:34 pgsql: Reintroduce dead tuple counter in pg_stat_progress_vacuum.
Previous Message Michael Paquier 2024-06-14 00:30:07 pgsql: doc: Fix description WAL summarizer in glossary