From: | Nathan Bossart <nathan(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: test_slru: Fix LWLock tranche allocation in EXEC_BACKEND builds. |
Date: | 2025-09-09 19:10:31 |
Message-ID: | [email protected] |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
test_slru: Fix LWLock tranche allocation in EXEC_BACKEND builds.
Currently, test_slru's shmem_startup_hook unconditionally generates
new LWLock tranche IDs. This is fine on non-EXEC_BACKEND builds,
where only the postmaster executes this hook, but on EXEC_BACKEND
builds, every backend executes it, too. To fix, only generate the
tranche IDs in the postmaster process by checking the
IsUnderPostmaster variable.
This is arguably a bug fix and could be back-patched, but since the
damage is limited to some extra unused tranche IDs in a test
module, I'm not going to bother.
Reported-by: Sami Imseih <samimseih(at)gmail(dot)com>
Reviewed-by: Sami Imseih <samimseih(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAA5RZ0vaAuonaf12CeDddQJu5xKL%2B6xVyS%2B_q1%2BcH%3D33JXV82w%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/530cfa8eb50ca5a2151dfc50a6a5999ec8aff148
Modified Files
--------------
src/test/modules/test_slru/test_slru.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2025-09-09 19:36:57 | pgsql: Fix documentation for shmem_startup_hook. |
Previous Message | Peter Eisentraut | 2025-09-09 13:42:13 | pgsql: Fix typo in comment |