pgsql: Fix internal error from CollateExpr in SQL/JSON DEFAULT expressi

From: Amit Langote <amitlan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix internal error from CollateExpr in SQL/JSON DEFAULT expressi
Date: 2025-10-09 02:07:12
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix internal error from CollateExpr in SQL/JSON DEFAULT expressions

SQL/JSON functions such as JSON_VALUE could fail with "unrecognized
node type" errors when a DEFAULT clause contained an explicit COLLATE
expression. That happened because assign_collations_walker() could
invoke exprSetCollation() on a JsonBehavior expression whose DEFAULT
still contained a CollateExpr, which exprSetCollation() does not
handle.

For example:

SELECT JSON_VALUE('{"a":1}', '$.c' RETURNING text
DEFAULT 'A' COLLATE "C" ON EMPTY);

Fix by validating in transformJsonBehavior() that the DEFAULT
expression's collation matches the enclosing JSON expression’s
collation. In exprSetCollation(), replace the recursive call on the
JsonBehavior expression with an assertion that its collation already
matches the target, since the parser now enforces that condition.

Reported-by: Jian He <jian(dot)universality(at)gmail(dot)com>
Author: Jian He <jian(dot)universality(at)gmail(dot)com>
Reviewed-by: Amit Langote <amitlangote09(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACJufxHVwYYSyiVQ6o+PsRX6zQ7rAFinh_fv1kCfTsT1xG4Zeg@mail.gmail.com
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/09f86a42f25cd32d8d268484252671341033b2c0

Modified Files
--------------
src/backend/nodes/nodeFuncs.c | 8 +---
src/backend/parser/parse_expr.c | 57 ++++++++++++++++++++++----
src/test/regress/expected/collate.icu.utf8.out | 49 ++++++++++++++++++++++
src/test/regress/sql/collate.icu.utf8.sql | 15 ++++++-
4 files changed, 114 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2025-10-09 02:07:25 pgsql: Fix internal error from CollateExpr in SQL/JSON DEFAULT expressi
Previous Message Amit Langote 2025-10-09 01:21:06 pgsql: Fix internal error from CollateExpr in SQL/JSON DEFAULT expressi