| Lists: | pgsql-committerspgsql-hackers |
|---|
| From: | alvherre(at)postgresql(dot)org (Alvaro Herrera) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Avoid MSVC breakage caused by my previous commit by not using a |
| Date: | 2009-03-07 02:09:22 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Log Message:
-----------
Avoid MSVC breakage caused by my previous commit by not using a variable in
the src/bin/scripts Makefile.
Modified Files:
--------------
pgsql/src/bin/scripts:
Makefile (r1.41 -> r1.42)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/Makefile?r1=1.41&r2=1.42)
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Avoid MSVC breakage caused by my previous commit by not using a |
| Date: | 2009-03-07 16:35:03 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> Avoid MSVC breakage caused by my previous commit by not using a variable in
> the src/bin/scripts Makefile.
Buildfarm says it's still broken.
regards, tom lane
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Avoid MSVC breakage caused by my previous commit by not using a |
| Date: | 2009-03-07 19:38:34 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> > Avoid MSVC breakage caused by my previous commit by not using a variable in
> > the src/bin/scripts Makefile.
>
> Buildfarm says it's still broken.
Hmm, yeah, apparently Mkvcbuild.pm needs to be updated with the list of
files that need to be symlinked -- and it's not all that
straightforward.
I need some help here, as I have no way to test this.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Avoid MSVC breakage caused by my previous commit by not using a |
| Date: | 2009-03-08 19:14:44 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Tom Lane wrote:
>> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
>>> Avoid MSVC breakage caused by my previous commit by not using a variable in
>>> the src/bin/scripts Makefile.
>> Buildfarm says it's still broken.
>
> Hmm, yeah, apparently Mkvcbuild.pm needs to be updated with the list of
> files that need to be symlinked -- and it's not all that
> straightforward.
>
> I need some help here, as I have no way to test this.
This should be fixed per my commit a minute ago. Thanks for help over IM
to figure it out :-)
//Magnus