| Lists: | pgsql-committers |
|---|
| From: | alvherre(at)postgresql(dot)org (Alvaro Herrera) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2009-04-14 00:06:35 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
Log Message:
-----------
pg_restore -jN does not equate "multiple jobs", so partly revert the
previous patch.
Per note from Tom.
Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_restore.c (r1.98 -> r1.99)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_restore.c?r1=1.98&r2=1.99)
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)postgresql(dot)org>, Andrew Dunstan <adunstan(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2009-04-14 09:49:08 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
On Tue, 2009-04-14 at 00:06 +0000, Alvaro Herrera wrote:
> Log Message:
> -----------
> pg_restore -jN does not equate "multiple jobs", so partly revert the
> previous patch.
I notice that the release notes talk about "parallel restore", yet the
word parallel is not used in the docs anywhere. The section on restoring
a dump makes no mention of this new facility, nor does the perf tips
section.
Also says that the option doesn't work with --single-transaction, so we
should say that you've added in TRUNCATE to make the COPY go faster (or
haven't you? I know we discussed it).
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)postgresql(dot)org>, Andrew Dunstan <adunstan(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2009-04-14 11:33:23 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
Simon Riggs wrote:
> Also says that the option doesn't work with --single-transaction, so we
> should say that you've added in TRUNCATE to make the COPY go faster (or
> haven't you? I know we discussed it).
>
>
Yes, it does use TRUNCATE.
cheers
andrew
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)postgresql(dot)org>, Andrew Dunstan <adunstan(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2010-02-26 02:32:18 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
Simon Riggs wrote:
>
> On Tue, 2009-04-14 at 00:06 +0000, Alvaro Herrera wrote:
> > Log Message:
> > -----------
> > pg_restore -jN does not equate "multiple jobs", so partly revert the
> > previous patch.
>
> I notice that the release notes talk about "parallel restore", yet the
> word parallel is not used in the docs anywhere. The section on restoring
> a dump makes no mention of this new facility, nor does the perf tips
> section.
>
> Also says that the option doesn't work with --single-transaction, so we
> should say that you've added in TRUNCATE to make the COPY go faster (or
> haven't you? I know we discussed it).
Good point. Documentation patch attached and applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/diff | text/x-diff | 1.3 KB |
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)postgresql(dot)org>, Andrew Dunstan <adunstan(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2010-02-26 18:20:48 |
| Message-ID: | 1267208448.20134.1165.camel@ebony |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
On Thu, 2010-02-25 at 21:32 -0500, Bruce Momjian wrote:
> Simon Riggs wrote:
> >
> > On Tue, 2009-04-14 at 00:06 +0000, Alvaro Herrera wrote:
> > > Log Message:
> > > -----------
> > > pg_restore -jN does not equate "multiple jobs", so partly revert the
> > > previous patch.
> >
> > I notice that the release notes talk about "parallel restore", yet the
> > word parallel is not used in the docs anywhere. The section on restoring
> > a dump makes no mention of this new facility,
The doc patch you applied does nothing to address these points
> nor does the perf tips
> > section.
Only that one.
> > Also says that the option doesn't work with --single-transaction, so we
> > should say that you've added in TRUNCATE to make the COPY go faster (or
> > haven't you? I know we discussed it).
>
> Good point. Documentation patch attached and applied.
>
--
Simon Riggs www.2ndQuadrant.com
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)postgresql(dot)org>, Andrew Dunstan <adunstan(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2010-02-26 18:25:04 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
Simon Riggs wrote:
> On Thu, 2010-02-25 at 21:32 -0500, Bruce Momjian wrote:
> > Simon Riggs wrote:
> > >
> > > On Tue, 2009-04-14 at 00:06 +0000, Alvaro Herrera wrote:
> > > > Log Message:
> > > > -----------
> > > > pg_restore -jN does not equate "multiple jobs", so partly revert the
> > > > previous patch.
> > >
> > > I notice that the release notes talk about "parallel restore", yet the
> > > word parallel is not used in the docs anywhere. The section on restoring
> > > a dump makes no mention of this new facility,
>
> The doc patch you applied does nothing to address these points
We don't usually modify past release notes.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)postgresql(dot)org>, Andrew Dunstan <adunstan(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2010-02-26 18:37:19 |
| Message-ID: | 1267209439.20134.1231.camel@ebony |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
On Fri, 2010-02-26 at 13:25 -0500, Bruce Momjian wrote:
> Simon Riggs wrote:
> > On Thu, 2010-02-25 at 21:32 -0500, Bruce Momjian wrote:
> > > Simon Riggs wrote:
> > > >
> > > > On Tue, 2009-04-14 at 00:06 +0000, Alvaro Herrera wrote:
> > > > > Log Message:
> > > > > -----------
> > > > > pg_restore -jN does not equate "multiple jobs", so partly revert the
> > > > > previous patch.
> > > >
> > > > I notice that the release notes talk about "parallel restore", yet the
> > > > word parallel is not used in the docs anywhere. The section on restoring
> > > > a dump makes no mention of this new facility,
> >
> > The doc patch you applied does nothing to address these points
>
> We don't usually modify past release notes.
Cool, but my comment has nothing to do with that. Please reread.
--
Simon Riggs www.2ndQuadrant.com
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)postgresql(dot)org>, Andrew Dunstan <adunstan(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: pg_restore -jN does not equate "multiple jobs", so partly revert |
| Date: | 2010-02-27 03:46:23 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
Simon Riggs wrote:
> On Fri, 2010-02-26 at 13:25 -0500, Bruce Momjian wrote:
> > Simon Riggs wrote:
> > > On Thu, 2010-02-25 at 21:32 -0500, Bruce Momjian wrote:
> > > > Simon Riggs wrote:
> > > > >
> > > > > On Tue, 2009-04-14 at 00:06 +0000, Alvaro Herrera wrote:
> > > > > > Log Message:
> > > > > > -----------
> > > > > > pg_restore -jN does not equate "multiple jobs", so partly revert the
> > > > > > previous patch.
> > > > >
> > > > > I notice that the release notes talk about "parallel restore", yet the
> > > > > word parallel is not used in the docs anywhere. The section on restoring
> > > > > a dump makes no mention of this new facility,
> > >
> > > The doc patch you applied does nothing to address these points
> >
> > We don't usually modify past release notes.
>
> Cool, but my comment has nothing to do with that. Please reread.
I don't see any performance mentions in the restore docs so I am unclear
why we should add them there:
http://developer.postgresql.org/pgdocs/postgres/backup-dump.html#BACKUP-DUMP-RESTORE
We mention all the performance stuff in the performance section:
http://developer.postgresql.org/pgdocs/postgres/populate.html#POPULATE-PG-DUMP
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +