pgsql: Fix MSVC builds for previous patch's addition of a src/port file

Lists: pgsql-committers
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix MSVC builds for previous patch's addition of a src/port file
Date: 2012-02-29 05:24:11
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Fix MSVC builds for previous patch's addition of a src/port file.

(And why in the world is this OBJS list not being scraped from the
corresponding Makefile?)

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8cae5810ebaaabb54171d9953bdd9cc802f0d135

Modified Files
--------------
src/tools/msvc/Mkvcbuild.pm | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix MSVC builds for previous patch's addition of a src/port file
Date: 2012-02-29 21:54:49
Message-ID: CABUevExtQqBaDscDU0rSFKjkZ2x+3tp1qtubUiE=sX+NjcfupA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Wed, Feb 29, 2012 at 06:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fix MSVC builds for previous patch's addition of a src/port file.
>
> (And why in the world is this OBJS list not being scraped from the
> corresponding Makefile?)

IIRC that's because the list of object files is dependent on configure
output, and we don't run configure on msvc. We could get parts via
scraping and parts manually, but it just seemed more consistent to get
it all the same way.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/