pgsql: pg_upgrade: fix one-byte per empty db memory leak

Lists: pgsql-committers
From: Bruce Momjian <bruce(at)momjian(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_upgrade: fix one-byte per empty db memory leak
Date: 2015-01-09 17:12:33
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

pg_upgrade: fix one-byte per empty db memory leak

Report by Tatsuo Ishii, Coverity

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ac7009abd228362042edd10e6b12556ddef35171

Modified Files
--------------
contrib/pg_upgrade/relfilenode.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: fix one-byte per empty db memory leak
Date: 2015-07-21 13:01:55
Message-ID: CAB7nPqSC=njuC+_0pXRLcm_gMuQNbYwoAtZTg9pqxSkmbJiMTg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Sat, Jan 10, 2015 at 2:12 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> pg_upgrade: fix one-byte per empty db memory leak
>
> Report by Tatsuo Ishii, Coverity

Shouldn't this commit be backpatched where needed.?
--
Michael

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: fix one-byte per empty db memory leak
Date: 2015-07-21 13:29:32
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Michael Paquier wrote:
> On Sat, Jan 10, 2015 at 2:12 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > pg_upgrade: fix one-byte per empty db memory leak
> >
> > Report by Tatsuo Ishii, Coverity
>
> Shouldn't this commit be backpatched where needed.?

A one byte leak? Come again.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: fix one-byte per empty db memory leak
Date: 2015-07-21 13:38:00
Message-ID: CAB7nPqRdxJkHhttJDswpgYFdvZyrD9df_Q686nVquCX96MAfzg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Tue, Jul 21, 2015 at 10:29 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>> On Sat, Jan 10, 2015 at 2:12 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> > pg_upgrade: fix one-byte per empty db memory leak
>> >
>> > Report by Tatsuo Ishii, Coverity
>>
>> Shouldn't this commit be backpatched where needed.?
>
> A one byte leak? Come again.

Just for the sake of correctness, nothing else (/me leaves to sleep).
--
Michael