pgsql: Push limit through subqueries to underlying sort, where possible

Lists: pgsql-committers
From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Push limit through subqueries to underlying sort, where possible
Date: 2017-08-21 18:42:56
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Push limit through subqueries to underlying sort, where possible.

Douglas Doole, reviewed by Ashutosh Bapat and by me. Minor formatting
change by me.

Discussion: http://postgr.es/m/CADE5jYLuugnEEUsyW6Q_4mZFYTxHxaVCQmGAsF0yiY8ZDggi-w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1f6d515a67ec98194c23a5db25660856c9aab944

Modified Files
--------------
src/backend/executor/nodeLimit.c | 26 +++++++++++++++++
src/test/regress/expected/subselect.out | 52 +++++++++++++++++++++++++++++++++
src/test/regress/sql/subselect.sql | 46 +++++++++++++++++++++++++++++
3 files changed, 124 insertions(+)


From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Push limit through subqueries to underlying sort, where possible
Date: 2017-08-23 21:55:13
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On 2017-08-21 18:42:56 +0000, Robert Haas wrote:
> Push limit through subqueries to underlying sort, where possible.
>
> Douglas Doole, reviewed by Ashutosh Bapat and by me. Minor formatting
> change by me.
>
> Discussion: http://postgr.es/m/CADE5jYLuugnEEUsyW6Q_4mZFYTxHxaVCQmGAsF0yiY8ZDggi-w@mail.gmail.com

This seems to have caused some buildfarm failures:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2017-08-23%2019%3A15%3A01
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mantid&dt=2017-08-23%2019%3A33%3A18

(note the commits they started failing after)

- Andres


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Push limit through subqueries to underlying sort, where possible
Date: 2017-08-23 22:42:40
Message-ID: CA+Tgmoaf+6eVYbmBHVZ21Akdk9uba3U4d=dgZfXFzjgZhExrjA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Wed, Aug 23, 2017 at 5:55 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-08-21 18:42:56 +0000, Robert Haas wrote:
>> Push limit through subqueries to underlying sort, where possible.
>>
>> Douglas Doole, reviewed by Ashutosh Bapat and by me. Minor formatting
>> change by me.
>>
>> Discussion: http://postgr.es/m/CADE5jYLuugnEEUsyW6Q_4mZFYTxHxaVCQmGAsF0yiY8ZDggi-w@mail.gmail.com
>
> This seems to have caused some buildfarm failures:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2017-08-23%2019%3A15%3A01
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mantid&dt=2017-08-23%2019%3A33%3A18
>
> (note the commits they started failing after)

Yeah, I noticed that earlier but didn't get time to reply. I've now
replied on the original thread.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company