| Lists: | pgsql-committers |
|---|
| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Doc: replace unnecessary non-breaking space with ordinal space. |
| Date: | 2024-10-01 03:00:15 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
Doc: replace unnecessary non-breaking space with ordinal space.
There were unnecessary non-breaking spaces (nbsp, U+00A0, 0xc2a0 in
UTF-8) in the docs. This commit replaces them with ASCII spaces
(0x20).
config.sgml is backpatched through 17.
ref/drop_extension.sgml is backpatched through 13.
Discussion: https://postgr.es/m/20240930.153404.202479334310259810.ishii%40postgresql.org
Reviewed-by: Yugo Nagata, Daniel Gustafsson
Backpatch-through: 17, 13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3b1a377defcfc01d8a3f964e39aa652766ffc188
Modified Files
--------------
doc/src/sgml/config.sgml | 2 +-
doc/src/sgml/ref/drop_extension.sgml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Doc: replace unnecessary non-breaking space with ordinal space. |
| Date: | 2024-10-01 06:51:30 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
Ishii-san,
On Tue, Oct 01, 2024 at 03:00:15AM +0000, Tatsuo Ishii wrote:
> Doc: replace unnecessary non-breaking space with ordinal space.
>
> There were unnecessary non-breaking spaces (nbsp, U+00A0, 0xc2a0 in
> UTF-8) in the docs. This commit replaces them with ASCII spaces
> (0x20).
>
> config.sgml is backpatched through 17.
> ref/drop_extension.sgml is backpatched through 13.
>
> Discussion: https://postgr.es/m/20240930.153404.202479334310259810.ishii%40postgresql.org
> Reviewed-by: Yugo Nagata, Daniel Gustafsson
> Backpatch-through: 17, 13
It seems to me that you have forgotten to apply your patch on
REL_17_STABLE. Or am I missing something?
--
Michael
| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Doc: replace unnecessary non-breaking space with ordinal space. |
| Date: | 2024-10-01 07:32:23 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
> Ishii-san,
>
> On Tue, Oct 01, 2024 at 03:00:15AM +0000, Tatsuo Ishii wrote:
>> Doc: replace unnecessary non-breaking space with ordinal space.
>>
>> There were unnecessary non-breaking spaces (nbsp, U+00A0, 0xc2a0 in
>> UTF-8) in the docs. This commit replaces them with ASCII spaces
>> (0x20).
>>
>> config.sgml is backpatched through 17.
>> ref/drop_extension.sgml is backpatched through 13.
>>
>> Discussion: https://postgr.es/m/20240930.153404.202479334310259810.ishii%40postgresql.org
>> Reviewed-by: Yugo Nagata, Daniel Gustafsson
>> Backpatch-through: 17, 13
>
> It seems to me that you have forgotten to apply your patch on
> REL_17_STABLE. Or am I missing something?
Thank you for letting know me. I pushed it. But I noticed that now
the commit's author time and commit time are different after pushed
it. Should I revert ot and push it again?
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Doc: replace unnecessary non-breaking space with ordinal space. |
| Date: | 2024-10-01 07:39:58 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
On Tue, Oct 01, 2024 at 04:32:23PM +0900, Tatsuo Ishii wrote:
> Thank you for letting know me. I pushed it. But I noticed that now
> the commit's author time and commit time are different after pushed
> it. Should I revert ot and push it again?
You have applied a cherry-pick, from what I can see. There is no
point in reverting and re-pushing for that, IMO, because there is also
a point in keeping the author timestamp close to the original ones
when doing a cherry-pick of a past commit on a stable branch :)
--
Michael
| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Doc: replace unnecessary non-breaking space with ordinal space. |
| Date: | 2024-10-01 08:15:28 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
> You have applied a cherry-pick, from what I can see.
Yes, I did and "git pull" later on.
> There is no
> point in reverting and re-pushing for that, IMO, because there is also
> a point in keeping the author timestamp close to the original ones
> when doing a cherry-pick of a past commit on a stable branch :)
Ok, I leave it as it is.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp