Closed Bug 1840327 Opened 2 years ago Closed 2 years ago

snap nightly build fails with undeclared identifier 'isnan'

Categories

(Firefox Build System :: Third Party Packaging, defect)

Firefox 116
Unspecified
Linux
defect

Tracking

(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox114 unaffected, firefox115 unaffected, firefox116 fixed)

RESOLVED FIXED
116 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox114 --- unaffected
firefox115 --- unaffected
firefox116 --- fixed

People

(Reporter: gerard-majax, Assigned: jfkthame)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

https://github.com/canonical/firefox-snap/actions/runs/5372854666/jobs/9746648786#step:6:26614

118:41.11 In file included from Unified_cpp_gfx_thebes0.cpp:92:
118:41.11 /root/parts/firefox/build/gfx/thebes/gfxFont.cpp:4256:7: error: use of undeclared identifier 'isnan'
118:41.11   if (isnan(result.mAlphabetic)) {
118:41.11       ^
118:41.14    Compiling headers-core v0.2.0
118:41.20    Compiling cookie v0.16.2
118:41.22 /root/parts/firefox/build/gfx/thebes/gfxFont.cpp:4259:7: error: use of undeclared identifier 'isnan'
118:41.22   if (isnan(result.mHanging)) {
118:41.22       ^
118:41.32 /root/parts/firefox/build/gfx/thebes/gfxFont.cpp:4262:7: error: use of undeclared identifier 'isnan'
118:41.32   if (isnan(result.mIdeographic)) {
118:41.32       ^
Flags: needinfo?(bandali)
Component: Audio/Video → Third Party Packaging
Product: Core → Firefox Build System
Keywords: regression
OS: Unspecified → Linux
Regressed by: 1840075
Summary: snap nightly build is broken → snap nightly build fails with undeclared identifier 'isnan'
Version: unspecified → Firefox 116
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED

Thanks for the report. I believe this should resolve the breakage. If you're able to confirm this, that'd be great -- thanks!

Flags: needinfo?(lissyx+mozillians)

Sebastian, can you try the patch on your side ? My snapcraft setup is broken as result of power loss this weekend that wrecked one of my filesystems, it wont be before a few hours at best this part is up and running again

Flags: needinfo?(lissyx+mozillians) → needinfo?(seb128)

Amin, could you give it a try?

Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ae0c4e9bc90 Explicitly use std:: namespace to refer to isnan(). r=gfx-reviewers,lsalzman

looks like I've been able to get back my snap work env sooner than anticipated, I could confirm the issue locally and I'm finishing a build with the patch

Flags: needinfo?(seb128)
Flags: needinfo?(bandali)

No surprise but I can confirm a build success

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

a build has been retriggered so the edge channel on the store should be uptodate soonish

Set release status flags based on info from the regressing bug 1840075

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: