Snap edge channel has lost Nightly logo branding
Categories
(Firefox Build System :: Third Party Packaging, defect)
Tracking
(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox114 unaffected, firefox115 unaffected, firefox116 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox-esr115 | --- | unaffected |
| firefox114 | --- | unaffected |
| firefox115 | --- | unaffected |
| firefox116 | --- | fixed |
People
(Reporter: ke5trel, Assigned: gerard-majax)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(2 files)
Unbranded logo in snap build
The snap package edge channel has started using the unbranded logo instead of the Nightly logo in the most recent build 116.0a1 2023-06-30 (2848).
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Hm, 2835 was fine.
|
|
Assignee | |
Comment 2•2 years ago
|
||
I'm not sure what changed between 2835 and 2848 ?
|
|
Assignee | |
Comment 3•2 years ago
|
||
ok it seems to be my fault: $ git log --oneline --no-merges 94da35b3c84a512b8146e1815b7a6635df004640..ca3e92d4acc11805458d2a81ff6f2a4908319ebc
|
|
Assignee | |
Comment 4•2 years ago
|
||
Looks to be due to https://github.com/canonical/firefox-snap/commit/636a6716f31717569e1e13f9628ba1d93620c3d9 but it makes no sense to me.
|
|
Assignee | |
Comment 5•2 years ago
|
||
I think it's a dumb mistake, the aforthmentionned patch moved stuff in a way that made export MOZCONFIG="$SNAPCRAFT_STAGE/mozconfig" part of override-pull but we actually need this also in override-build
|
|
Assignee | |
Comment 6•2 years ago
|
||
|
|
Assignee | |
Comment 7•2 years ago
|
||
fix has been merged, but github actions is acting (low disk space) so it's going to take a bit before a new nightly release is done
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
I can confirm the nightly build from a few hours ago today includes Alexandre's fix and the official branding is being used again.
And as for disk space, indeed. This is the second time in the recent months I've had to resort to manually freeing up some disk space in GitHub's runners; we need to find a more sustainable longer-term solution.
Description
•