fix $thing parameter in deprecation helper

See https://github.com/dokuwiki/dokuwiki/commit/615810c59cd1bbc7a6f950fa667bd0c75f92d99a#r161070574

code style: line breaks

coding style: control flow whitespaces

address issues mention in PR#4045

codestyle adjustments: function declaration braces/spaces

Apply rector renames

apply PSR-12 constant visibility rule

PSR-12 says constants need their visibility declared from PHP 7.1
onwards

Apply rector fixes to inc/Extension and inc/Debug

fix codestyle

another go at #3717

c0ece86a0ac0cfab0856b056fb3ce8e726855542 was wrong too, because most
deprecation logs drop the callee

Another fix for #3717

The deprecation mechanism did actually log the wrong file (callee
instead of caller). This was fixed and the message adjusted again.

A guardian for very short backtraces and l

Another fix for #3717

The deprecation mechanism did actually log the wrong file (callee
instead of caller). This was fixed and the message adjusted again.

A guardian for very short backtraces and large offsets was added

show more ...

log deprecation messages independent from allowdebug

Only the logging configuration should influnece if deprecation messages
are to be logged. By default they should be logged.

Fixes caller position when logging deprecated data

The backtrace lists the caller position for the called method. The code
assumed it to be the position of the methof itself.

Merge branch 'logging'

* logging:
added JavaScript based filter mechanism
added logging configuration
replaced out calls to dbglog with new Logger calls
added convenience methods to log to o

Merge branch 'logging'

* logging:
added JavaScript based filter mechanism
added logging configuration
replaced out calls to dbglog with new Logger calls
added convenience methods to log to our default facilities
added logviwer admin plugin
added log dir to git
central logging mechanism

show more ...

better deprecation messages for self required plugin base files

central logging mechanism

This introduces a logger mechanism and a new data/log directory. This is
a first proof of concept. It's built on top of the new global error
handling mechanism

Things to d

central logging mechanism

This introduces a logger mechanism and a new data/log directory. This is
a first proof of concept. It's built on top of the new global error
handling mechanism

Things to discuss:

* should we adopt PSR-3 somehow? if yes, how and should plugins be able
to drop-in other psr3 loggers?
* how to configure which facilities shall be logged?
* should we implement a log deletion feature?
* is the log format sensible?
* should we implement a log viewer admin plugin?
* should logging trigger events (it should maybe replace the
deprecation event)

show more ...

fix undefined index notice in DebugHelper::dbgDeprecatedFunction

Restore some backwards compatibility for injected handlers

Some plugins, for example the move plugin, use their own handler class.
We need to give these plugins time to adjust their code.

This shou

Restore some backwards compatibility for injected handlers

Some plugins, for example the move plugin, use their own handler class.
We need to give these plugins time to adjust their code.

This should restore the functionality of the move plugin. We still need
to extract the handler class itself.

It also adds another debug method for triggering the deprecation event,
since none of the two existing methods are suitable here. This
dbgCustomDeprecationEvent method should be used sparingly and only where
the other two don't work.

Co-authored-by: Phy <[email protected]>

show more ...

Avoid accessing the evet system before it's intialized

reimplements cbfa1cdd75e162a1a8fac054453f4554f96e3362

First go at moving the plugin classes into their own namespace

Refactor deprecation logging into its own class

This gives us the flexibility to handle both deprecated properties and
methods/functions properly.