Imports may not be named like local classes. fixes #4200

For compatibility reasons we let our old `cache` class inherit from
`dokuwiki\Cache\Cache` but `cache` equals `Cache`. At least on some PHP
v

Imports may not be named like local classes. fixes #4200

For compatibility reasons we let our old `cache` class inherit from
`dokuwiki\Cache\Cache` but `cache` equals `Cache`. At least on some PHP
versions? I did not see any problem on my local machine running PHP 8.2
but the problem was visible on a machine running 8.1.27

show more ...

Apply rector fixes to the rest of inc

deprecated trigger_event() in favor of a static method on Event

Remove PHP user deprecation errors

Remove these errors pending proper discussion.
These errors could be a problem for installations that have HTML errors on
in production. Since DokuWikis is often

Remove PHP user deprecation errors

Remove these errors pending proper discussion.
These errors could be a problem for installations that have HTML errors on
in production. Since DokuWikis is often used in smaller and private
contexts, this is a scenario that should be considered.

show more ...

Refactor deprecation logging into its own class

This gives us the flexibility to handle both deprecated properties and
methods/functions properly.

Use DokuWiki's own deprecation reporters

DokuWiki has its own way to report deprecation notifications.
Let's use it!

Refactor cache.php into different files

moved Parser to Parsing namespace

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

remove DOKU_INC checks

There is no need for this check, since these files should not have any
main code that is executed on direct call.

Fixes PSR1.Files.SideEffects.FoundWithSymbols

replace some var keywords

This should fix some tests on PHP 7.1. The work is far from done, we
still have a lot of variables without proper accessibility defined.

yet another class constructor

another class_name to __construct

update parent constructor calls to use __construct()

more class constructors to __construct()

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PH

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PHP 5.3 now, there's no need to supress any error here
anymore. This might even give a minor performance boost.

show more ...

Merge remote-tracking branch 'origin/master' into scrutinizerissues

Conflicts:
inc/media.php
inc/plugin.php
inc/template.php
lib/plugins/authplain/_test/escaping.test.php
lib/plugins/syntax.php

code formatting cache

scrutinizer documentations issues

declare field

Fix longstanding issue with cache class & cachetime setting

1. cachetime setting should only be applied to the cache_renderer
class. Previously it was applied to cache_parser (and by
extensio

Fix longstanding issue with cache class & cachetime setting

1. cachetime setting should only be applied to the cache_renderer
class. Previously it was applied to cache_parser (and by
extension cache_handler).
2. two special cachetime values, -1 & 0, weren't handled, per
FS#2183

To handle the cachetime setting, -1, disable caching, a new
property _nocache is added. When that property is true, any cache
file must not be used and storecache() should not store any values

show more ...

Fix caching (make the event callback public again)

Caching had been completely broken (disabled) for caches with events
because the default event handler (cache::_useCache()) was protected and
thus

Fix caching (make the event callback public again)

Caching had been completely broken (disabled) for caches with events
because the default event handler (cache::_useCache()) was protected and
thus couldn't be executed by the event handler. This was broken in
c59b3e001d1e8258b1d118909257b70516c8a6b1

show more ...

PHPDocs of cache classes

add visibility keywords and PHPDocs for cache

Add dynamic declared _time attribute to cache object