Skip to content

chore: update erc20 changelog to match .md file #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

chore: update erc20 changelog to match .md file #670

merged 1 commit into from
Feb 28, 2023

Conversation

kliao
Copy link
Collaborator

@kliao kliao commented Feb 28, 2023 •
edited
Loading

Description

Publish was failing https://github.com/0xProject/protocol/actions/runs/4289008519/jobs/7471624112


Error: Found CHANGELOG version lower then current package version. @0x/contracts-erc20 current: 4.0.0, Changelog: 3.3.57
    at Object.shouldAddNewChangelogEntry (/home/runner/work/protocol/protocol/node_modules/@0x/monorepo-scripts/lib/utils/changelog_utils.js:58:19)
    at /home/runner/work/protocol/protocol/node_modules/@0x/monorepo-scripts/lib/publish.js:172:72
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/protocol/protocol/node_modules/@0x/monorepo-scripts/lib/publish.js:6:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Testing instructions

Types of changes

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@kliao kliao changed the title update erc20 changelog to match .md file chore: update erc20 changelog to match .md file Feb 28, 2023
@kliao kliao marked this pull request as ready for review February 28, 2023 03:08
@kliao kliao requested a review from kyu-c February 28, 2023 03:10
kyu-c
kyu-c approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@kyu-c kyu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamp might be needed if it's already published

@kliao kliao merged commit 3ab12ed into development Feb 28, 2023
@kliao kliao deleted the chore/update-changelog branch February 28, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyu-c kyu-c kyu-c approved these changes

@dekz dekz Awaiting requested review from dekz dekz is a code owner

@dextracker dextracker Awaiting requested review from dextracker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kliao @kyu-c