Skip to content

feat: removing L2 Encoding from AaveV3 MixIn [LIT-901] #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

feat: removing L2 Encoding from AaveV3 MixIn [LIT-901] #676

merged 1 commit into from
Mar 9, 2023

Conversation

SavDont
Copy link
Contributor

@SavDont SavDont commented Mar 9, 2023

Description

Removing the L2 Encoding for Aave V3 MixIn. The L2 encoding makes settlement more brittle and is causing some high revert rates specifically for MultiHop tokens involving Aave V3 tokens.

Testing instructions

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@SavDont SavDont requested review from dekz and dextracker as code owners March 9, 2023 15:12
@SavDont SavDont requested a review from kyu-c March 9, 2023 15:22
@SavDont SavDont changed the title feat: removing L2 Encoding from AaveV3 MixIn feat: removing L2 Encoding from AaveV3 MixIn [LIT-901] Mar 9, 2023
dextracker
dextracker approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@dextracker dextracker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

duncancmt
duncancmt approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@duncancmt duncancmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change improves gas efficiency on L2 because the original feature was not a good match with the L2 calldata fee model. These changes should also be backwards compatible because extra bridgeData should get ignored

@SavDont SavDont merged commit 3e939f7 into development Mar 9, 2023
@SavDont SavDont deleted the feat/aaveV3RemoveL2Encoding branch March 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncancmt duncancmt duncancmt approved these changes

@dextracker dextracker dextracker approved these changes

@dekz dekz Awaiting requested review from dekz dekz is a code owner

@kyu-c kyu-c Awaiting requested review from kyu-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SavDont @duncancmt @dextracker