Skip to content

Extendable Bridge Adapter #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

joshrrose
Copy link
Member

Description

Makes Bridge adapter infinitely extendable.

Now there is a single bridge adapter that handles all chains. The large list of liquidity sources is broken down in groups BridgeAdapterGroup1 and BridgeAdapterGroup2. that the BridgeAdapter will dispatch between by BridgeProtocolId

I re-did this changes because there were a lot of changes on top and rebase wasn't working very cleanly.

I have used simbot to test on a few different chains. First i would remove all of the liquidity sources to prove my override worked. then after seeing many failures I would put the liquidity source back and run simbot again making sure that the run was clean.

Testing instructions

Types of changes

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

Copy link
Contributor

@dextracker dextracker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 19, 2023
@github-actions github-actions bot closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants