-
Notifications
You must be signed in to change notification settings - Fork 212
Migrate NFT Support, Protocol, an d Governance docs from docs.0x.org into Protocol docs #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/get-pip.py
should not be included in this repo. it's available from pypa.io
@@ -0,0 +1,48 @@ | |||
Generating 0x Order Hashes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't appear to concern NFT royalties, but instead how to hash the limit order struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, updated this page
Removed |
These CI tests don't appear to be docs related. Is this okay to merge @duncancmt ? |
we merged the NFT, protocol, and governance docs in PR #675 - proposing that we can close this PR |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Migrating 3 sections from https://docs.0x.org/ into the Protocol docs as they are more relevant to 0x Protocol than 0x Labs.
Testing instructions
See build instructions here: https://github.com/0xProject/protocol/tree/development/docs
Types of changes