Skip to content

Migrate NFT Support, Protocol, an d Governance docs from docs.0x.org into Protocol docs #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

jlin27
Copy link
Contributor

@jlin27 jlin27 commented Mar 30, 2023

Description

Migrating 3 sections from https://docs.0x.org/ into the Protocol docs as they are more relevant to 0x Protocol than 0x Labs.

Testing instructions

See build instructions here: https://github.com/0xProject/protocol/tree/development/docs

Types of changes

  • Update Exchange Proxy section
  • Add additional details for NativeOrders, ERC721Orders, and ERC1155Orders Features
  • Add Signatures schemes
  • Add files for NFT Support section:
    • Creating Orders, Royalties and Fees, Collection Offers
    • Signing Orders, On-chain Orders
    • Filling Orders
    • Cancelling Orders
    • Fetching NFT Order Data
  • Update Governance section with the following:
    • Governance Participants
    • Types of Votes
    • Community Treasury
    • Apply for a 0xDAO Grant (v2)
    • How to Delegate ZRX
    • How to Vote

Copy link
Collaborator

@duncancmt duncancmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/get-pip.py should not be included in this repo. it's available from pypa.io

@@ -0,0 +1,48 @@
Generating 0x Order Hashes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't appear to concern NFT royalties, but instead how to hash the limit order struct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated this page

@elenadimitrova elenadimitrova removed their request for review April 1, 2023 15:10
@jlin27
Copy link
Contributor Author

jlin27 commented Apr 2, 2023

docs/get-pip.py should not be included in this repo. it's available from pypa.io

Removed docs/get-pip.py

@jlin27
Copy link
Contributor Author

jlin27 commented Apr 10, 2023

These CI tests don't appear to be docs related. Is this okay to merge @duncancmt ?

@wonge97
Copy link
Collaborator

wonge97 commented May 8, 2023

we merged the NFT, protocol, and governance docs in PR #675 - proposing that we can close this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 8, 2023
@github-actions github-actions bot closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants