Skip to content

fix: remove vm.stopPrank if vm.startPrank not present #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2023

Conversation

SavDont
Copy link
Contributor

@SavDont SavDont commented May 1, 2023

Description

Closes LIT-1020.
tl;dr: Foundry CI tests are failing due to the new version of forge reverting if we call vm.stopPrank without calling vm.startPrank.

Testing instructions

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@SavDont SavDont requested review from dekz and dextracker as code owners May 1, 2023 16:49
@SavDont SavDont requested a review from kyu-c May 1, 2023 16:49
@SavDont SavDont merged commit 5a47f04 into development May 1, 2023
@SavDont SavDont deleted the fix/foundryCITestsVMPrank branch May 1, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants